Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: wrong execution when CTE meet non-correlated subquery #44054

Merged
merged 5 commits into from
May 22, 2023
Merged

planner: wrong execution when CTE meet non-correlated subquery #44054

merged 5 commits into from
May 22, 2023

Conversation

winoros
Copy link
Member

@winoros winoros commented May 22, 2023

What problem does this PR solve?

Issue Number: close #44051

Problem Summary:

What is changed and how it works?

The early execution might miss the pushed predicates, causing wrong results.
Thus we disable the early execution for the plan segment containing CTE consumers.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix the issue that TiDB might get wrong results when CTE is used in non-correlated subquery

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 22, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • time-and-fate
  • wjhuang2016

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/needs-triage-completed labels May 22, 2023
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 22, 2023
@winoros winoros requested a review from wjhuang2016 May 22, 2023 08:36
@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. and removed do-not-merge/needs-triage-completed labels May 22, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 22, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 22, 2023
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 22, 2023
@winoros winoros changed the title planner: wrong execution when CTE meet non-correlated subquery planner: wrong execution when CTE meet non-correlated subquery | tidb-test=pr/2133 May 22, 2023
@winoros
Copy link
Member Author

winoros commented May 22, 2023

/retest

@winoros
Copy link
Member Author

winoros commented May 22, 2023

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 22, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 933ed5e

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 22, 2023
@winoros winoros changed the title planner: wrong execution when CTE meet non-correlated subquery | tidb-test=pr/2133 planner: wrong execution when CTE meet non-correlated subquery May 22, 2023
@ti-chi-bot ti-chi-bot bot merged commit d82ed59 into pingcap:master May 22, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request May 22, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #44071.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 22, 2023
@winoros @ti-chi-bot
This is an automated cherry-pick of pingcap#44054
0353f1f 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request May 22, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #44072.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 22, 2023
@winoros @ti-chi-bot
This is an automated cherry-pick of pingcap#44054
b304e13 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request May 22, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #44073.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 22, 2023
@winoros @ti-chi-bot
This is an automated cherry-pick of pingcap#44054
adc5cde 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
This was referenced May 22, 2023
Merged
Closed
ti-chi-bot bot pushed a commit that referenced this pull request May 23, 2023
@ti-chi-bot
planner: wrong execution when CTE meet non-correlated subquery (#44054)…
533ee67 
… (#44071)

close #44051
winoros added a commit to winoros/tidb that referenced this pull request May 31, 2023
@winoros
planner: wrong execution when CTE meet non-correlated subquery (pingc…
899a7a3 
…ap#44054)
@winoros winoros mentioned this pull request May 31, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this pull request May 31, 2023
@ti-chi-bot
planner: wrong execution when CTE meet non-correlated subquery (#44054)…
bae60c5 
… (#44073)

close #44051
ti-chi-bot bot pushed a commit that referenced this pull request May 31, 2023
@winoros
planner: cherry pick two CTE related commit (#44306)
064a4e5 
ref #43759, ref #44054
@winoros winoros deleted the fix-cte-scalar-subquery branch June 1, 2023 02:49
ti-chi-bot bot pushed a commit that referenced this pull request Jun 30, 2023
@ti-chi-bot
planner: wrong execution when CTE meet non-correlated subquery (#44054)…
8c01c23 
… (#44072)

close #44051
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@time-and-fate time-and-fate time-and-fate approved these changes

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong result when CTE used in non-correlated scalar subquery
4 participants
@winoros @ti-chi-bot @wjhuang2016 @time-and-fate