*: fix cte miss cleaning spilled-disk file #44501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: guo-shaoge <shaoge1994@163.com>
ti-chi-bot
bot
added
release-note-none
Signed-off-by: guo-shaoge <shaoge1994@163.com>
Signed-off-by: guo-shaoge <shaoge1994@163.com>
ti-chi-bot
bot
added
size/L
|
/test unit-test |
wshwsh12
approved these changes
Jun 8, 2023
wshwsh12
approved these changes
Jun 8, 2023
ti-chi-bot
bot
added
needs-1-more-lgtm
XuHuaiyu
approved these changes
Jun 8, 2023
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wshwsh12, XuHuaiyu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
AilinKid
changed the title
12 tasks
|
In response to a cherrypick label: new pull request created to branch |
12 tasks
|
In response to a cherrypick label: new pull request created to branch |
ti-chi-bot
pushed a commit
to ti-chi-bot/tidb
that referenced
this pull request
Jun 8, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created to branch |
12 tasks
ti-chi-bot
pushed a commit
to ti-chi-bot/tidb
that referenced
this pull request
Jun 8, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
12 tasks
|
In response to a cherrypick label: new pull request created to branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #44477
Problem Summary:
Close record set for select stmt and insert/update stmt is in different code path.
Miss calling
resetCTEStoragefor insert/update stmt, whose recordSet is nil.What is changed and how it works?
resetCTEStorage()in handleNoDelay(), this will cover insert/update.. DML stmt.resetCTEStorage() in(a *ExecStmt) CloseRecordSet`, this will cover select stmt. Also for prepare/execute/plan cache/select for update.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.