-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: Exchange part schema load fix (#46126) #46191
ddl: Exchange part schema load fix (#46126) #46191
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
This reverts commit f574f79.
…6126-to-release-6.5
/retest |
/retest |
/reopen |
@JaySon-Huang: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Reopen it because #45980 is backport to release-6.5 and it make TiFlash hangs after executing exchange partition |
…6126-to-release-6.5
/test unit-test |
@JaySon-Huang: No presubmit jobs available for pingcap/tidb@release-6.5 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #46191 +/- ##
================================================
Coverage ? 73.6675%
================================================
Files ? 1084
Lines ? 348304
Branches ? 0
================================================
Hits ? 256587
Misses ? 75247
Partials ? 16470 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bb7133, mjonss The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/merge |
@bb7133: We have migrated to builtin Please use
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This is an automated cherry-pick of #46126
What problem does this PR solve?
Issue Number: ref #46125 close #45791
Problem Summary:
What is changed and how it works?
Check List
Tests
Manual test:
Build this PR and use it for starting a cluster
tiup playground --db.binpath ./bin/tidb-server
and then run tiflash test
sh run-test.sh fullstack-test2/ddl/alter_exchange_partition.test
which no longer failsAlso check the tidb.log that there are no failures loading new schema diffs, so no full schema reloads are needed.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
(Unless 7.4 get released without this fix).