Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip first state change of EXCHANGE Partition. (#7945) #8099

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #7945

It only generates warnings/errors and the first state change does not affect TiFlash, it only sets an internal field ExchangePartitionInfo

It is only the second stage transition that is interesting for TiFlash

Should be combined with pingcap/tidb#46125

What problem does this PR solve?

Issue Number: close #7941

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. labels Sep 15, 2023
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Sep 15, 2023
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 15, 2023
@JaySon-Huang
Copy link
Contributor

/run-all-tests

@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 15, 2023
@JaySon-Huang
Copy link
Contributor

/run-all-tests

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Sep 15, 2023
@JaySon-Huang
Copy link
Contributor

Seems it is blocked by the related PR is not merged to tidb. pingcap/tidb#46191

@JaySon-Huang JaySon-Huang assigned mjonss and unassigned JaySon-Huang Sep 15, 2023
@JaySon-Huang
Copy link
Contributor

Verified it works well with pingcap/tidb#46191

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 15, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 15, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 15, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 15, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-15 11:05:37.560069805 +0000 UTC m=+256303.527657840: ☑️ agreed by JaySon-Huang.
  • 2023-09-15 11:11:01.005247053 +0000 UTC m=+256626.972835120: ☑️ agreed by Lloyd-Pottiger.

@mjonss
Copy link
Contributor

mjonss commented Sep 16, 2023

/retest

@mjonss
Copy link
Contributor

mjonss commented Sep 17, 2023

/run-all-tests

@ti-chi-bot ti-chi-bot bot merged commit d21cded into pingcap:release-6.5 Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants