Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: use cmp.Compare to replace types.Compare #46657

Merged
merged 6 commits into from
Sep 5, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Sep 5, 2023

What problem does this PR solve?

Issue Number: ref #45933

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Sep 5, 2023
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #46657 (7e2f781) into master (19e888f) will decrease coverage by 0.6965%.
Report is 2 commits behind head on master.
The diff coverage is 89.8305%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #46657        +/-   ##
================================================
- Coverage   73.3655%   72.6690%   -0.6966%     
================================================
  Files          1315       1336        +21     
  Lines        395585     401870      +6285     
================================================
+ Hits         290223     292035      +1812     
- Misses        86902      91296      +4394     
- Partials      18460      18539        +79     
Flag Coverage Δ
integration 25.3693% <33.8983%> (?)
unit 73.3560% <88.1355%> (-0.0095%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 84.9581% <ø> (+0.0061%) ⬆️
br 48.1240% <ø> (-4.3357%) ⬇️

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei hawkingrei changed the title *: use cmp.Compare to replace CompareDuration *: use cmp.Compare to replace types.Compare Sep 5, 2023
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 5, 2023
@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 5, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 5, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-05 05:23:45.985311768 +0000 UTC m=+2422990.534327754: ☑️ agreed by lance6716.
  • 2023-09-05 06:33:03.667570778 +0000 UTC m=+2427148.216586765: ☑️ agreed by xhebox.

@ti-chi-bot ti-chi-bot bot merged commit 5dd4296 into pingcap:master Sep 5, 2023
5 of 9 checks passed
@hawkingrei hawkingrei deleted the use_cmp branch September 5, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants