Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration to Standard Library for exp/slices and exp/maps Packages #45933

Closed
hawkingrei opened this issue Aug 9, 2023 · 4 comments · Fixed by #46107
Closed

Migration to Standard Library for exp/slices and exp/maps Packages #45933

hawkingrei opened this issue Aug 9, 2023 · 4 comments · Fixed by #46107
Assignees
@yashvardhanmishra
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.

Comments

@hawkingrei
Copy link
Member

Enhancement

With the latest release of Go, we have introduced the new slices and maps packages in the standard library. These packages provide improved functionality and support generic operations on slices and maps of any element or key type.
To leverage the benefits of the standard library and ensure better code maintainability, we need to migrate our codebase from the exp/slices and exp/maps packages to the standard library equivalents.
@hawkingrei hawkingrei added the type/enhancement The issue or PR belongs to an enhancement. label Aug 9, 2023
@hawkingrei hawkingrei mentioned this issue Aug 9, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue Aug 9, 2023
@hawkingrei
*: replace exp/maps with std/maps (#45928)
b4bfeee 
ref #45933
@hawkingrei hawkingrei added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Aug 9, 2023
@hawkingrei hawkingrei pinned this issue Aug 9, 2023
@yashvardhanmishra
Copy link

/assign

@hawkingrei
Copy link
Member Author

@yashvardhanmishra Thank you. too many code need to update. so you can choose part to migrate.

This was referenced Aug 10, 2023
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this issue Aug 11, 2023
@hawkingrei
*: replace exp/slices with std (#45978)
0eac1db 
ref #45933
ti-chi-bot bot pushed a commit that referenced this issue Aug 11, 2023
@hawkingrei
br: replace exp/slices with std (#45986)
66033d5 
ref #45933
@fatelei fatelei mentioned this issue Aug 11, 2023
Merged
12 tasks
@hawkingrei hawkingrei mentioned this issue Aug 12, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue Aug 14, 2023
@hawkingrei
*: use std slices to replace exp/slices (#46020)
61ecb59 
ref #45933
ti-chi-bot bot pushed a commit that referenced this issue Aug 14, 2023
@fatelei
statistics: using standard lib slices instead of exp slices (#45996)
60588b9 
ref #45933
@hawkingrei hawkingrei mentioned this issue Aug 14, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue Aug 14, 2023
@hawkingrei
util: use std/slices to replace exp/slices (#46052)
7bd1790 
ref #45933
@hawkingrei hawkingrei mentioned this issue Aug 14, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue Aug 15, 2023
@hawkingrei
*: use std/slices to replace exp/slices (#46079)
2a674bc 
ref #45933
@Defined2014 Defined2014 mentioned this issue Aug 15, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue Aug 15, 2023
@Defined2014
util: remove useless codes (#46096)
3846e80 
ref #45933
@hawkingrei hawkingrei mentioned this issue Aug 15, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue Aug 15, 2023
@hawkingrei
*: use std/slices to replace exp/slices (#46107)
04f96b5 
close #45933
@hawkingrei hawkingrei reopened this Aug 15, 2023
@hawkingrei hawkingrei mentioned this issue Aug 16, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue Aug 16, 2023
@hawkingrei
*: use std/slices to replace exp/slices (#46128)
95b4dcc 
ref #45933
This was referenced Aug 17, 2023
Closed
Merged
@hawkingrei hawkingrei mentioned this issue Aug 21, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue Aug 22, 2023
@hawkingrei
*: use std/slices to replace exp/slices (#46292)
7e476a5 
ref #45933
@hawkingrei hawkingrei mentioned this issue Aug 23, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue Aug 23, 2023
@hawkingrei
*: use std/slices to replace exp/slices (#46339)
14fb817 
ref #45933
@hawkingrei hawkingrei mentioned this issue Aug 24, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue Aug 24, 2023
@hawkingrei
*: use std/slices to replace exp/slices (#46373)
3352a61 
ref #45933
@xzhangxian1008 xzhangxian1008 mentioned this issue Aug 25, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue Aug 25, 2023
@xzhangxian1008
*: use std/slices to replace exp/slices (#46422)
8b30d3d 
ref #45933
@hawkingrei hawkingrei mentioned this issue Aug 26, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue Aug 28, 2023
@hawkingrei
*: use std/slices to replace exp/slices (#46433)
c11a999 
ref #45933
@hawkingrei hawkingrei mentioned this issue Sep 5, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue Sep 5, 2023
@hawkingrei
*: use cmp.Compare to replace types.Compare (#46657)
5dd4296 
ref #45933
@hawkingrei hawkingrei mentioned this issue Sep 14, 2023
Merged
12 tasks
@hawkingrei
Copy link
Member Author

/test all

ti-chi-bot bot pushed a commit that referenced this issue Sep 15, 2023
@hawkingrei
statistics: use slices.BinarySearchFunc to simple TopN.FindTopN (#46996)
9ec7872 
ref #45933
@hawkingrei hawkingrei mentioned this issue Sep 15, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue Sep 15, 2023
@hawkingrei
statistics: use slices.SortStableFunc to simple SortSampleItems (#47009)
beb2a36 
ref #45933
@hawkingrei hawkingrei mentioned this issue Sep 18, 2023
Closed
13 tasks
@hawkingrei hawkingrei mentioned this issue Oct 17, 2023
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Oct 17, 2023
@hawkingrei
*: replace mathutil.Max/Min with built-in max/min (#47700)
895b4e0 
ref #45933
@hawkingrei hawkingrei mentioned this issue Oct 23, 2023
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Oct 25, 2023
@hawkingrei
*: replace mathutil.Max/Min with built-in max/min (#47939)
cd0587e 
ref #45933
@hawkingrei hawkingrei mentioned this issue Dec 10, 2023
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Dec 11, 2023
@hawkingrei
*: replace exp/maps with std/maps (#49315)
bcbccaf 
ref #45933
@hawkingrei
Copy link
Member Author

I think all the old package has been migrated into the new one.

@hawkingrei hawkingrei unpinned this issue Dec 28, 2023
wuhuizuo pushed a commit to wuhuizuo/tidb that referenced this issue Apr 2, 2024
@hawkingrei @wuhuizuo
*: replace mathutil.Max/Min with built-in max/min (pingcap#47700)
57b49c7 
ref pingcap#45933
@ti-chi-bot ti-chi-bot mentioned this issue Jun 4, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yashvardhanmishra yashvardhanmishra

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

*: use std/slices to replace exp/slices hawkingrei/tidb
2 participants
@hawkingrei @yashvardhanmishra