Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: replace mathutil.Max/Min with built-in max/min #47700

Merged
merged 3 commits into from
Oct 17, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Oct 17, 2023

What problem does this PR solve?

Issue Number: ref #45933

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked do-not-merge/needs-linked-issue labels Oct 17, 2023
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 17, 2023
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 17, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 17, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 17, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-17 05:39:43.397930769 +0000 UTC m=+1721980.985040907: ☑️ agreed by lance6716.
  • 2023-10-17 05:40:47.972396999 +0000 UTC m=+1722045.559507146: ☑️ agreed by 3pointer.

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #47700 (5df80b9) into master (4765838) will increase coverage by 0.9059%.
Report is 6 commits behind head on master.
The diff coverage is 82.0754%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #47700        +/-   ##
================================================
+ Coverage   71.8952%   72.8011%   +0.9059%     
================================================
  Files          1396       1421        +25     
  Lines        405013     411459      +6446     
================================================
+ Hits         291185     299547      +8362     
+ Misses        94207      93070      -1137     
+ Partials      19621      18842       -779     
Flag Coverage Δ
integration 41.3441% <34.6938%> (?)
unit 71.8999% <86.1386%> (+0.0046%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser ∅ <ø> (∅)
br 48.6879% <60.0000%> (-4.2461%) ⬇️

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei hawkingrei changed the title *: use built-in max/min with mathutil.Max/Min *: replace mathutil.Max/Min with built-in max/min Oct 17, 2023
@ti-chi-bot ti-chi-bot bot merged commit 895b4e0 into pingcap:master Oct 17, 2023
3 checks passed
@hawkingrei hawkingrei deleted the replace_mathutil_with_min branch October 17, 2023 07:26
wuhuizuo pushed a commit to wuhuizuo/tidb that referenced this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants