-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log Backup: decouple log backup resolve locks from GCWorker. (#45904) #46893
Log Backup: decouple log backup resolve locks from GCWorker. (#45904) #46893
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GCWorker part LGTM
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #46893 +/- ##
================================================
Coverage ? 73.6863%
================================================
Files ? 1084
Lines ? 348260
Branches ? 0
================================================
Hits ? 256620
Misses ? 75174
Partials ? 16466 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BornChanger, Leavrth The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This is an automated cherry-pick of #45904
What problem does this PR solve?
Issue Number: close #40759
Problem Summary:
#35403 introduce 1 minute scan locks of the whole cluster in GCWorker. which will cost CPU when cluster has large number of regions. This PR try to decouple it.
What is changed and how it works?
ResolveLocksForRange
into gcutil.go to avoid cycle import.Check List
Tests
before this PR, resolve lock every minutes
with this PR. resolve lock every 10 minutes. which will save CPU usage.
and check lock resolved.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.