planner: move `index_usage` code into a separate package #47163

qw4990 · 2023-09-21T07:22:07Z

What problem does this PR solve?

Issue Number: ref #46905

Problem Summary: planner: move index_usage code into a separate package

What is changed and how it works?

No logical change, just code movement.

planner: move index_usage code into a separate package

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

tiprow · 2023-09-21T07:22:37Z

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

statistics/handle/handle.go

ti-chi-bot · 2023-09-21T07:42:48Z

[LGTM Timeline notifier]

Timeline:

2023-09-21 07:28:52.832671944 +0000 UTC m=+761698.800259979: ☑️ agreed by hawkingrei.
2023-09-21 07:42:47.681743768 +0000 UTC m=+762533.649331803: ☑️ agreed by AilinKid.

codecov · 2023-09-21T07:45:43Z

Codecov Report

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #47163        +/-   ##
================================================
- Coverage   72.9964%   72.6794%   -0.3171%     
================================================
  Files          1338       1360        +22     
  Lines        399462     405778      +6316     
================================================
+ Hits         291593     294917      +3324     
- Misses        89018      92141      +3123     
+ Partials      18851      18720       -131

Flag	Coverage Δ
integration	`31.0122% <4.4642%> (?)`
unit	`73.0072% <93.7500%> (+0.0108%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`53.9913% <ø> (ø)`
parser	`84.9728% <ø> (+0.0107%)`	⬆️
br	`48.7385% <ø> (-4.3624%)`	⬇️

hawkingrei · 2023-09-21T07:48:19Z

/hold

hawkingrei · 2023-09-21T07:49:25Z

/unhold

Rustin170506

LGTM

ti-chi-bot · 2023-09-21T08:01:52Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, hawkingrei, hi-rustin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [AilinKid,hawkingrei,hi-rustin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

qw4990 · 2023-09-21T09:00:59Z

/test check-dev2

tiprow · 2023-09-21T09:01:34Z

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

qw4990 · 2023-09-21T09:30:06Z

/test unit-test

qw4990 · 2023-09-21T09:30:09Z

/test check-dev2

tiprow · 2023-09-21T09:30:40Z

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow · 2023-09-21T09:30:46Z

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hawkingrei · 2023-09-21T10:20:21Z

/retest

qw4990 · 2023-09-21T11:25:32Z

/test check-dev2

tiprow · 2023-09-21T11:26:04Z

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

qw4990 · 2023-09-21T13:56:01Z

/test check-dev2

tiprow · 2023-09-21T13:56:40Z

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

qw4990 · 2023-09-21T15:08:42Z

/test check-dev2

tiprow · 2023-09-21T15:09:12Z

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

qw4990 · 2023-09-22T00:23:34Z

/test check-dev2

tiprow · 2023-09-22T00:24:15Z

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

…usage

wuhuizuo · 2023-09-22T02:17:03Z

/test ?

ti-chi-bot · 2023-09-22T02:17:06Z

@wuhuizuo: The following commands are available to trigger required jobs:

/test build
/test canary-scan-security
/test check-dev
/test check-dev2
/test mysql-test
/test pingcap/tidb/canary_ghpr_unit_test
/test pull-br-integration-test
/test pull-common-test
/test pull-e2e-test
/test pull-integration-common-test
/test pull-integration-copr-test
/test pull-integration-ddl-test
/test pull-integration-jdbc-test
/test pull-integration-mysql-test
/test pull-integration-prisma-test
/test pull-mysql-connector-test
/test pull-sqllogic-test
/test pull-tiflash-test
/test unit-test

The following commands are available to trigger optional jobs:

/test pull-notify-when-compatibility-sections-changed

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/ghpr_build
pingcap/tidb/ghpr_check
pingcap/tidb/ghpr_check2
pingcap/tidb/ghpr_mysql_test
pingcap/tidb/ghpr_unit_test

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wuhuizuo · 2023-09-22T02:17:29Z

/test check-dev2

tiprow · 2023-09-22T02:17:33Z

@wuhuizuo: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow · 2023-09-22T02:18:11Z

@wuhuizuo: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wuhuizuo · 2023-09-22T02:50:20Z

/retest

wuhuizuo · 2023-09-22T02:50:32Z

/ok-to-test

wuhuizuo · 2023-09-22T03:25:38Z

/retest

fixup

4b76884

ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Sep 21, 2023

hawkingrei reviewed Sep 21, 2023

View reviewed changes

statistics/handle/handle.go Outdated Show resolved Hide resolved

qw4990 added 2 commits September 21, 2023 15:23

fixup

931add7

fixup

dd4b5f7

hawkingrei approved these changes Sep 21, 2023

View reviewed changes

ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 21, 2023

fixup

b218645

AilinKid approved these changes Sep 21, 2023

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 21, 2023

qw4990 added 2 commits September 21, 2023 15:44

fixup

8b1f63c

fixup

c36992b

ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 21, 2023

fixup

790e59b

ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 21, 2023

fixup

25f7354

Rustin170506 approved these changes Sep 21, 2023

View reviewed changes

qw4990 added 2 commits September 21, 2023 16:12

fixup

776f3a5

fixup

dadce61

fixup

aa2b402

Merge remote-tracking branch 'upstream/master' into statshandle-index…

b5f9ac2

…usage

wuhuizuo changed the title ~~planner: move index_usage code into a separate package~~ planner: move index_usage code into a separate package | pd=96ace89decdc0b5e0a050aa17ba4356057ec3b88 Sep 22, 2023

wuhuizuo changed the title ~~planner: move index_usage code into a separate package | pd=96ace89decdc0b5e0a050aa17ba4356057ec3b88~~ planner: move index_usage code into a separate package | pd=5b3d0172b0db653a97257373fac9ce9d9699c6f5 Sep 22, 2023

ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Sep 22, 2023

wuhuizuo changed the title ~~planner: move index_usage code into a separate package | pd=5b3d0172b0db653a97257373fac9ce9d9699c6f5~~ planner: move index_usage code into a separate package Sep 22, 2023

ti-chi-bot bot merged commit 8fcbcd9 into pingcap:master Sep 22, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

planner: move `index_usage` code into a separate package #47163

planner: move `index_usage` code into a separate package #47163

qw4990 commented Sep 21, 2023 •

edited

Loading

tiprow bot commented Sep 21, 2023

ti-chi-bot bot commented Sep 21, 2023

codecov bot commented Sep 21, 2023 •

edited

Loading

hawkingrei commented Sep 21, 2023

hawkingrei commented Sep 21, 2023

Rustin170506 left a comment

ti-chi-bot bot commented Sep 21, 2023

qw4990 commented Sep 21, 2023

tiprow bot commented Sep 21, 2023

qw4990 commented Sep 21, 2023

qw4990 commented Sep 21, 2023

tiprow bot commented Sep 21, 2023

tiprow bot commented Sep 21, 2023

hawkingrei commented Sep 21, 2023

qw4990 commented Sep 21, 2023

tiprow bot commented Sep 21, 2023

qw4990 commented Sep 21, 2023

tiprow bot commented Sep 21, 2023

qw4990 commented Sep 21, 2023

tiprow bot commented Sep 21, 2023

qw4990 commented Sep 22, 2023

tiprow bot commented Sep 22, 2023

wuhuizuo commented Sep 22, 2023

ti-chi-bot bot commented Sep 22, 2023

wuhuizuo commented Sep 22, 2023

tiprow bot commented Sep 22, 2023

tiprow bot commented Sep 22, 2023

wuhuizuo commented Sep 22, 2023

wuhuizuo commented Sep 22, 2023

wuhuizuo commented Sep 22, 2023

planner: move index_usage code into a separate package #47163

planner: move index_usage code into a separate package #47163

Conversation

qw4990 commented Sep 21, 2023 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

tiprow bot commented Sep 21, 2023

ti-chi-bot bot commented Sep 21, 2023

[LGTM Timeline notifier]

codecov bot commented Sep 21, 2023 • edited Loading

Codecov Report

hawkingrei commented Sep 21, 2023

hawkingrei commented Sep 21, 2023

Rustin170506 left a comment

Choose a reason for hiding this comment

ti-chi-bot bot commented Sep 21, 2023

qw4990 commented Sep 21, 2023

tiprow bot commented Sep 21, 2023

qw4990 commented Sep 21, 2023

qw4990 commented Sep 21, 2023

tiprow bot commented Sep 21, 2023

tiprow bot commented Sep 21, 2023

hawkingrei commented Sep 21, 2023

qw4990 commented Sep 21, 2023

tiprow bot commented Sep 21, 2023

qw4990 commented Sep 21, 2023

tiprow bot commented Sep 21, 2023

qw4990 commented Sep 21, 2023

tiprow bot commented Sep 21, 2023

qw4990 commented Sep 22, 2023

tiprow bot commented Sep 22, 2023

wuhuizuo commented Sep 22, 2023

ti-chi-bot bot commented Sep 22, 2023

wuhuizuo commented Sep 22, 2023

tiprow bot commented Sep 22, 2023

tiprow bot commented Sep 22, 2023

wuhuizuo commented Sep 22, 2023

wuhuizuo commented Sep 22, 2023

wuhuizuo commented Sep 22, 2023

planner: move `index_usage` code into a separate package #47163

planner: move `index_usage` code into a separate package #47163

qw4990 commented Sep 21, 2023 •

edited

Loading

codecov bot commented Sep 21, 2023 •

edited

Loading