-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
types, stmtctx, *: use ZeroDate, ZeroInDate and InvalidDate related flags to replace variable in statement context #47794
Conversation
/check-issue-triage-complete |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #47794 +/- ##
================================================
+ Coverage 71.7365% 72.9870% +1.2505%
================================================
Files 1401 1424 +23
Lines 405704 413528 +7824
================================================
+ Hits 291038 301822 +10784
+ Misses 94917 92843 -2074
+ Partials 19749 18863 -886
Flags with carried forward coverage won't be shown. Click here to find out more.
|
9c03d83
to
0983af6
Compare
/retest |
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
cdc8e4d
to
d794f57
Compare
50c65f8
to
c26c4f2
Compare
/retest |
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
[LGTM Timeline notifier]Timeline:
|
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lightning/domain part lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3pointer, D3Hunter, lcwangchao, xhebox, zanmato1984 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close #47508, close #47507
Problem Summary:
This PR replaces the field
NoZeroDate
,IgnoreZeroInDate
andAllowInvalidDate
to the flag in types context.Check List
Tests
They are all covered by existing tests