ddl: remove useless code in adjustWorkerSize

[lcwangchao]

What problem does this PR solve?

Issue Number: ref #53388

Problem Summary:

This line seems useless now:

tidb/pkg/ddl/backfilling_scheduler.go

Line 280 in afd2343

sessCtx.GetSessionVars().StmtCtx.InCreateOrAlterStmt = true

This line is first introduced in PR #25728, and this line disallows 0 value when altering a column from integer to time.

However, after PR #47794, it seems not necessary because this change does the same work.

Currently, InCreateOrAlterStmt is only read by ResetContextOfStmt which will never be called in DDL worker. So we can remove this line safely.

What changed and how does it work?

Remove sessCtx.GetSessionVars().StmtCtx.InCreateOrAlterStmt = true because it is useless now.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.
    Just run regression test TestCastFromZeroIntToTimeError

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @lcwangchao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.6312%. Comparing base (afd2343) to head (fd70213).
Report is 5 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #53644        +/-   ##
================================================
+ Coverage   72.5370%   74.6312%   +2.0941%     
================================================
  Files          1506       1506                
  Lines        430741     431212       +471     
================================================
+ Hits         312447     321819      +9372     
+ Misses        98968      89470      -9498     
- Partials      19326      19923       +597     

Flag	Coverage Δ
integration	49.2737% <ø> (?)
unit	71.5034% <ø> (-0.0261%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	53.9957% <ø> (ø)
parser	∅ <ø> (∅)
br	50.5184% <ø> (+8.7132%)	⬆️

[lcwangchao]

/retest

[tiprow]

@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[YangKeao]

LGTM

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tangenta, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/ddl/OWNERS [tangenta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-05-29 07:57:45.563777578 +0000 UTC m=+2849619.320913151: ☑️ agreed by tangenta.
• 2024-05-29 09:30:16.689563898 +0000 UTC m=+2855170.446699473: ☑️ agreed by YangKeao.

[tiprow]

@lcwangchao: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
fast_test_tiprow	fd70213	link	true	/test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.