Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: unify the use of PD API URL constants #48132

Merged
merged 7 commits into from
Nov 1, 2023
Merged

*: unify the use of PD API URL constants #48132

merged 7 commits into from
Nov 1, 2023

Conversation

JmPotato
Copy link
Member

What problem does this PR solve?

Issue Number: ref #35319.

What is changed and how it works?

Unify the use of PD API URL constants to make sure it can be maintained more easily.

Check List

Tests

  • Unit test
  • Integration test

Release note

None

@JmPotato
Unify the use of PD API URL constants
4cf2b24 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 31, 2023
@JmPotato
Copy link
Member Author

/cc @hawkingrei @nolouch

@hawkingrei
Copy link
Member

Great job.

It is a better way to supply a pd client library for tidb.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 31, 2023
@JmPotato
Add ConfigWithTTLSeconds and SchedulerWithName
704b348 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@CabinfeverB
Copy link
Contributor

Great job.

It is a better way to supply a pd client library for tidb.

a HTTP client?

@JmPotato
Fix TestStoreInfo
fc2abe8 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@codecov
Copy link

codecov bot commented Oct 31, 2023 •
edited
Loading

Codecov Report

Merging #48132 (171e66d) into master (cc12200) will increase coverage by 1.3900%.
Report is 19 commits behind head on master.
The diff coverage is 50.6849%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #48132        +/-   ##
================================================
+ Coverage   71.5920%   72.9821%   +1.3900%     
================================================
  Files          1400       1424        +24     
  Lines        405894     414456      +8562     
================================================
+ Hits         290588     302479     +11891     
+ Misses        95488      93106      -2382     
+ Partials      19818      18871       -947
Flag Coverage Δ
integration 42.6871% <0.0000%> (?)
unit 71.7848% <50.6849%> (+0.1927%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 55.5260% <ø> (+1.4757%) ⬆️
parser ∅ <ø> (∅)
br 49.2385% <48.2758%> (-3.6594%) ⬇️

@hawkingrei
Copy link
Member

Great job.
It is a better way to supply a pd client library for tidb.

a HTTP client?

Yes, but it is enough for this pr.

@JmPotato
Fix TestTiKVProfileCPU
61f3f8a 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato
Copy link
Member Author

/retest-required

@JmPotato
Copy link
Member Author

/test check-dev2

@tiprow
Copy link

tiprow bot commented Oct 31, 2023

@JmPotato: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JmPotato
Add a call to ConfigWithTTLSeconds
c848992 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
nolouch
nolouch reviewed Oct 31, 2023
View reviewed changes
pkg/util/pdapi/const.go Outdated Show resolved Hide resolved
@JmPotato
Rename the RegionKey
ac5e679 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato JmPotato requested a review from nolouch October 31, 2023 07:55
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 31, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 31, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-31 06:54:38.558671493 +0000 UTC m=+2936076.145781638: ☑️ agreed by hawkingrei.
  • 2023-10-31 08:00:33.241524479 +0000 UTC m=+2940030.828634625: ☑️ agreed by nolouch.

@JmPotato
Refine the naming
171e66d 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato
Copy link
Member Author

@lance6716 @Leavrth Please help take a look, thx.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CabinfeverB, hawkingrei, lance6716, Leavrth, nolouch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 1, 2023
@JmPotato
Copy link
Member Author

JmPotato commented Nov 1, 2023

/test mysql-test

@tiprow tiprow
Copy link

tiprow bot commented Nov 1, 2023

@JmPotato: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JmPotato
Copy link
Member Author

JmPotato commented Nov 1, 2023

/test mysql-test

@tiprow tiprow
Copy link

tiprow bot commented Nov 1, 2023

@JmPotato: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JmPotato
Copy link
Member Author

JmPotato commented Nov 1, 2023

/test mysql-test

@tiprow tiprow
Copy link

tiprow bot commented Nov 1, 2023

@JmPotato: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit 733b10b into pingcap:master Nov 1, 2023
17 of 20 checks passed
@JmPotato JmPotato deleted the unify_pd_api_const branch November 1, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leavrth Leavrth Leavrth approved these changes

@CabinfeverB CabinfeverB CabinfeverB approved these changes

@nolouch nolouch nolouch approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

@lance6716 lance6716 lance6716 approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JmPotato @hawkingrei @CabinfeverB @lance6716 @nolouch @Leavrth