Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify the PD API request interface #35319

Open
JmPotato opened this issue Jun 13, 2022 · 1 comment
Open

Unify the PD API request interface #35319

JmPotato opened this issue Jun 13, 2022 · 1 comment
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@JmPotato
Copy link
Member

As #35268 and #35284 show, the PD API request lacks a unified interface, which causes the failover, error handling, and other necessary mechanisms to be missed. So I proposed that we should provide a unified PD API request interface inside TiDB rather than maintaining different implementations everywhere.
@JmPotato JmPotato added the type/enhancement The issue or PR belongs to an enhancement. label Jun 13, 2022
@JmPotato JmPotato changed the title Unified the PD API request interface Unify the PD API request interface Jun 13, 2022
@tangenta tangenta mentioned this issue Jun 27, 2022
Closed
@JmPotato JmPotato mentioned this issue Oct 31, 2023
Merged
2 tasks
ti-chi-bot bot pushed a commit that referenced this issue Nov 1, 2023
@JmPotato
*: unify the use of PD API URL constants (#48132)
733b10b 
ref #35319
@lhy1024
Copy link

lhy1024 commented Nov 2, 2023

etcd too?

This was referenced Nov 2, 2023
Open
Merged
@JmPotato JmPotato mentioned this issue Nov 14, 2023
Merged
3 tasks
ti-chi-bot bot pushed a commit that referenced this issue Nov 14, 2023
@JmPotato
*: upgrade and adapt to the new PD client (#48575)
911334b 
ref #35319
ti-chi-bot bot pushed a commit that referenced this issue Nov 15, 2023
@JmPotato
*: integrate PD HTTP client to the store helper (#48276)
0f35b6f 
ref #35319
@JmPotato JmPotato mentioned this issue Nov 15, 2023
Merged
3 tasks
ti-chi-bot bot pushed a commit that referenced this issue Nov 20, 2023
@JmPotato
*: further adaptation to PD HTTP client (#48606)
95759f4 
ref #35319
@JmPotato JmPotato mentioned this issue Nov 21, 2023
Merged
3 tasks
ti-chi-bot bot pushed a commit that referenced this issue Nov 23, 2023
@JmPotato
infosync: integrate PD HTTP client into the label manager (#48738)
7e8de2f 
ref #35319
@JmPotato JmPotato mentioned this issue Nov 23, 2023
Merged
3 tasks
ti-chi-bot bot pushed a commit that referenced this issue Nov 27, 2023
@JmPotato
infosync: integrate PD HTTP client into the placement manager (#48858)
c82e19c 
ref #35319
@JmPotato JmPotato mentioned this issue Nov 29, 2023
Merged
2 tasks
ti-chi-bot bot pushed a commit that referenced this issue Dec 1, 2023
@JmPotato
infosync: fully integrated PD HTTP client into InfoSyncer (#49006)
7353fbe 
ref #35319
@JmPotato JmPotato mentioned this issue Dec 4, 2023
Merged
3 tasks
ti-chi-bot bot pushed a commit that referenced this issue Dec 14, 2023
@JmPotato
infosync, helper: add caller ID to the PD HTTP client on the hot path (…
ecbaed6 
…#49134)

ref #35319
@JmPotato JmPotato mentioned this issue Dec 19, 2023
Merged
2 tasks
ti-chi-bot bot pushed a commit that referenced this issue Dec 19, 2023
@JmPotato
driver: update the PD HTTP client to support source mark (#49578)
a9317be 
ref #35319
@JmPotato JmPotato mentioned this issue Jan 9, 2024
Merged
2 tasks
ti-chi-bot bot pushed a commit that referenced this issue Jan 10, 2024
@JmPotato
deps, lightning: update the PD HTTP client to refine the retry logic (#…
528a6e3 
…50225)

close tikv/pd#7673, ref #35319
@ti-chi-bot ti-chi-bot mentioned this issue Jan 10, 2024
Merged
2 tasks
ti-chi-bot bot pushed a commit that referenced this issue Jan 10, 2024
@ti-chi-bot
deps, lightning: update the PD HTTP client to refine the retry logic (#…
acd3ddc 
…50225) (#50244)

close tikv/pd#7673, ref #35319
@CabinfeverB CabinfeverB mentioned this issue Jan 25, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Jan 26, 2024
@CabinfeverB
*: impl mock PD service discovery and update pd client version (#50718)
c072334 
ref #35319
@JmPotato JmPotato mentioned this issue Jun 4, 2024
Merged
2 tasks
ti-chi-bot bot pushed a commit that referenced this issue Jun 4, 2024
@JmPotato
go.mod: update the clients to adopt the latest fix/optimization (#53788)
8277203 
ref #35319
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JmPotato @lhy1024