Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps, lightning: update the PD HTTP client to refine the retry logic (#50225) #50244

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #50225

What problem does this PR solve?

Issue Number: ref #35319, close tikv/pd#7673.

Problem Summary:

Lightning updated the PD HTTP client but did not keep the same retry logic as before.

What changed and how does it work?

  • Update the PD HTTP client to adopt the latest retry logic.
  • Add a backoffer to the Lightning PD HTTP client to keep the same retry interval and frequency as before.

Check List

Tests

  • Unit test
  • Integration test

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

JmPotato and others added 5 commits January 10, 2024 03:31
Signed-off-by: JmPotato <ghzpotato@gmail.com>
Signed-off-by: JmPotato <ghzpotato@gmail.com>
Signed-off-by: JmPotato <ghzpotato@gmail.com>
Signed-off-by: lance6716 <lance6716@gmail.com>
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.6 labels Jan 10, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jan 10, 2024
@JmPotato
Copy link
Member

/cc @hawkingrei @lance6716 @YuJuncen

Please help approve this cherry-pick, thx a lot.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 10, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 10, 2024
Copy link

ti-chi-bot bot commented Jan 10, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-10 03:43:04.964788169 +0000 UTC m=+414774.549041841: ☑️ agreed by YuJuncen.
  • 2024-01-10 03:43:27.616747596 +0000 UTC m=+414797.201001298: ☑️ agreed by hawkingrei.

Copy link

ti-chi-bot bot commented Jan 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, lance6716, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 10, 2024
@JmPotato
Copy link
Member

/test unit-test

Copy link

tiprow bot commented Jan 10, 2024

@JmPotato: No presubmit jobs available for pingcap/tidb@release-7.6

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JmPotato
Copy link
Member

/test check-dev2

Copy link

tiprow bot commented Jan 10, 2024

@JmPotato: No presubmit jobs available for pingcap/tidb@release-7.6

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lance6716
Copy link
Contributor

/retest

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Merging #50244 (39705ac) into release-7.6 (6701bf1) will increase coverage by 0.0035%.
The diff coverage is 28.5714%.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           release-7.6     #50244        +/-   ##
===================================================
+ Coverage      70.0225%   70.0261%   +0.0035%     
===================================================
  Files             1436       1436                
  Lines           419055     419058         +3     
===================================================
+ Hits            293433     293450        +17     
+ Misses          105328     105327         -1     
+ Partials         20294      20281        -13     
Flag Coverage Δ
unit 70.0261% <28.5714%> (+0.0035%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0269% <ø> (ø)
parser ∅ <ø> (∅)
br 49.6861% <28.5714%> (+0.0180%) ⬆️

@ti-chi-bot ti-chi-bot bot merged commit acd3ddc into pingcap:release-7.6 Jan 10, 2024
31 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants