Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps, lightning: update the PD HTTP client to refine the retry logic #50225

Merged
merged 5 commits into from
Jan 10, 2024

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Jan 9, 2024

What problem does this PR solve?

Issue Number: ref #35319, close tikv/pd#7673.

Problem Summary:

Lightning updated the PD HTTP client but did not keep the same retry logic as before.

What changed and how does it work?

  • Update the PD HTTP client to adopt the latest retry logic.
  • Add a backoffer to the Lightning PD HTTP client to keep the same retry interval and frequency as before.

Check List

Tests

  • Unit test
  • Integration test

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 9, 2024
@JmPotato
Copy link
Member Author

JmPotato commented Jan 9, 2024

/retest

2 similar comments
@hawkingrei
Copy link
Member

/retest

@hawkingrei
Copy link
Member

/retest

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Merging #50225 (0df1377) into master (136ae46) will decrease coverage by 14.3789%.
Report is 2 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #50225         +/-   ##
=================================================
- Coverage   70.0612%   55.6823%   -14.3789%     
=================================================
  Files          1441       1548        +107     
  Lines        419730     582355     +162625     
=================================================
+ Hits         294068     324269      +30201     
- Misses       105349     235420     +130071     
- Partials      20313      22666       +2353     
Flag Coverage Δ
integration 36.4322% <85.7142%> (?)
unit 70.0276% <28.5714%> (-0.0337%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0269% <ø> (ø)
parser ∅ <ø> (∅)
br 55.2547% <100.0000%> (+5.5677%) ⬆️

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 9, 2024
@JmPotato
Copy link
Member Author

JmPotato commented Jan 9, 2024

/cc @hawkingrei @lance6716 @HuSharp

Signed-off-by: JmPotato <ghzpotato@gmail.com>
Signed-off-by: JmPotato <ghzpotato@gmail.com>
Signed-off-by: JmPotato <ghzpotato@gmail.com>
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 9, 2024
Signed-off-by: lance6716 <lance6716@gmail.com>
@JmPotato
Copy link
Member Author

JmPotato commented Jan 9, 2024

/test check-dev2

Copy link

tiprow bot commented Jan 9, 2024

@JmPotato: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@HuSharp HuSharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JmPotato
Copy link
Member Author

JmPotato commented Jan 9, 2024

do we need to update this? #49599 (files)

cc @lance6716

I believe we don't need to do so because the old retry logic has been added and the original disk calculating logic has been moved to checkDiskAvail below.

Copy link

ti-chi-bot bot commented Jan 9, 2024

@HuSharp: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JmPotato
Copy link
Member Author

JmPotato commented Jan 9, 2024

/cc @YuJuncen

PTAL, needs a BR approver, thx.

@ti-chi-bot ti-chi-bot bot requested a review from YuJuncen January 9, 2024 13:10
@JmPotato JmPotato changed the title deps: update the PD HTTP client to refine the retry logic deps, lightning: update the PD HTTP client to refine the retry logic Jan 9, 2024
@lance6716
Copy link
Contributor

need to cherry-pick to v7.6 to avoid lightning regression

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 10, 2024
Copy link

ti-chi-bot bot commented Jan 10, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-09 10:36:28.999249987 +0000 UTC m=+353178.583503660: ☑️ agreed by lance6716.
  • 2024-01-10 01:57:44.938188826 +0000 UTC m=+408454.522442514: ☑️ agreed by CabinfeverB.

Copy link

ti-chi-bot bot commented Jan 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CabinfeverB, HuSharp, lance6716, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 10, 2024
@ti-chi-bot ti-chi-bot bot merged commit 528a6e3 into pingcap:master Jan 10, 2024
30 of 34 checks passed
@JmPotato JmPotato deleted the update_pd_http_client branch January 10, 2024 03:30
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.6: #50244.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.6 release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add index failed with error '503 Service Unavailable' when kill pdleader
7 participants