-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps, lightning: update the PD HTTP client to refine the retry logic #50225
Conversation
/retest |
2 similar comments
/retest |
/retest |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #50225 +/- ##
=================================================
- Coverage 70.0612% 55.6823% -14.3789%
=================================================
Files 1441 1548 +107
Lines 419730 582355 +162625
=================================================
+ Hits 294068 324269 +30201
- Misses 105349 235420 +130071
- Partials 20313 22666 +2353
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: JmPotato <ghzpotato@gmail.com>
Signed-off-by: JmPotato <ghzpotato@gmail.com>
Signed-off-by: JmPotato <ghzpotato@gmail.com>
d9420d0
to
382569f
Compare
Signed-off-by: lance6716 <lance6716@gmail.com>
Signed-off-by: lance6716 <lance6716@gmail.com>
/test check-dev2 |
@JmPotato: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we don't need to do so because the old retry logic has been added and the original disk calculating logic has been moved to |
@HuSharp: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @YuJuncen PTAL, needs a BR approver, thx. |
need to cherry-pick to v7.6 to avoid lightning regression |
[LGTM Timeline notifier]Timeline:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CabinfeverB, HuSharp, lance6716, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: ref #35319, close tikv/pd#7673.
Problem Summary:
Lightning updated the PD HTTP client but did not keep the same retry logic as before.
What changed and how does it work?
Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.