Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: impl mock PD service discovery and update pd client version #50718

Merged
merged 8 commits into from
Jan 26, 2024

Conversation

CabinfeverB
Copy link
Contributor

@CabinfeverB CabinfeverB commented Jan 25, 2024

What problem does this PR solve?

Issue Number: ref #35319

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 25, 2024
Copy link

tiprow bot commented Jan 25, 2024

Hi @CabinfeverB. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@CabinfeverB
Copy link
Contributor Author

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed do-not-merge/needs-linked-issue labels Jan 25, 2024
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Merging #50718 (eb3d6f8) into master (40f0d16) will increase coverage by 2.6337%.
Report is 13 commits behind head on master.
The diff coverage is 51.4285%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #50718        +/-   ##
================================================
+ Coverage   72.1359%   74.7696%   +2.6337%     
================================================
  Files          1456       1458         +2     
  Lines        347738     423664     +75926     
================================================
+ Hits         250844     316772     +65928     
- Misses        76509      87064     +10555     
+ Partials      20385      19828       -557     
Flag Coverage Δ
integration 48.9028% <14.4927%> (?)
unit 70.2659% <44.2857%> (-1.8380%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0269% <ø> (-2.2860%) ⬇️
parser ∅ <ø> (∅)
br 56.7945% <83.3333%> (+4.5799%) ⬆️

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 25, 2024
br/pkg/pdutil/pd.go Outdated Show resolved Hide resolved
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
@CabinfeverB
Copy link
Contributor Author

/retest-required

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 25, 2024
Copy link

ti-chi-bot bot commented Jan 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-25 06:51:00.571051768 +0000 UTC m=+1029902.135349474: ☑️ agreed by lance6716.
  • 2024-01-25 07:31:21.750304603 +0000 UTC m=+1032323.314602307: ☑️ agreed by hawkingrei.

@hawkingrei
Copy link
Member

/retest

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
@CabinfeverB
Copy link
Contributor Author

/test build

Copy link

tiprow bot commented Jan 25, 2024

@CabinfeverB: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test tidb_parser_test
  • /test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lance6716
Copy link
Contributor

/cc @Leavrth

@ti-chi-bot ti-chi-bot bot requested a review from Leavrth January 25, 2024 09:50
@CabinfeverB CabinfeverB changed the title *: update pd client *: impl mock PD service discovery and update pd client version Jan 25, 2024
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
Copy link

ti-chi-bot bot commented Jan 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, lance6716, Leavrth, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 26, 2024
@ti-chi-bot ti-chi-bot bot merged commit c072334 into pingcap:master Jan 26, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants