Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

driver: update the PD HTTP client to support source mark #49578

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

JmPotato
Copy link
Member

What problem does this PR solve?

Issue Number: ref #35319, tikv/pd#7300.

Problem Summary:

Update the PD HTTP client to support source mark via tikv/pd#7565.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: JmPotato <ghzpotato@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 19, 2023
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 19, 2023
Copy link

ti-chi-bot bot commented Dec 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CabinfeverB, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 19, 2023
Copy link

ti-chi-bot bot commented Dec 19, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-19 06:20:59.236029549 +0000 UTC m=+941950.273256474: ☑️ agreed by hawkingrei.
  • 2023-12-19 06:25:53.066071556 +0000 UTC m=+942244.103298483: ☑️ agreed by CabinfeverB.

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Merging #49578 (ae1627d) into master (3a50bf6) will increase coverage by 0.5067%.
Report is 2 commits behind head on master.
The diff coverage is 0.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #49578        +/-   ##
================================================
+ Coverage   71.0037%   71.5104%   +0.5067%     
================================================
  Files          1368       1420        +52     
  Lines        399344     415520     +16176     
================================================
+ Hits         283549     297140     +13591     
- Misses        96005      99581      +3576     
+ Partials      19790      18799       -991     
Flag Coverage Δ
integration 43.8758% <0.0000%> (?)
unit 71.0038% <ø> (+0.0001%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 47.5759% <ø> (-5.3171%) ⬇️

@HuSharp
Copy link
Contributor

HuSharp commented Dec 19, 2023

/retest

@ti-chi-bot ti-chi-bot bot merged commit a9317be into pingcap:master Dec 19, 2023
16 checks passed
@JmPotato JmPotato deleted the update_pd_http_client branch December 20, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants