infosync: fully integrated PD HTTP client into InfoSyncer #49006

JmPotato · 2023-11-29T08:27:29Z

What problem does this PR solve?

Issue Number: ref #35319, tikv/pd#7300. Should merge after tikv/pd#7462.

Problem Summary:

Fully integrated PD HTTP client into InfoSyncer.

What changed and how does it work?

Replace the raw PD HTTP requests in InfoSyncer with the PD HTTP client completely.
Reuse the type definitions within the PD SDK as much as possible.

Check List

Tests

Unit test
Integration test

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: JmPotato <ghzpotato@gmail.com>

codecov · 2023-11-29T08:42:37Z

Codecov Report

Merging #49006 (f8cf570) into master (129be4c) will increase coverage by 1.2581%.
Report is 41 commits behind head on master.
The diff coverage is 23.3333%.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #49006        +/-   ##
================================================
+ Coverage   70.9775%   72.2357%   +1.2581%     
================================================
  Files          1368       1398        +30     
  Lines        404391     416878     +12487     
================================================
+ Hits         287027     301135     +14108     
+ Misses        97368      96800       -568     
+ Partials      19996      18943      -1053

Flag	Coverage Δ
integration	`43.8801% <23.3333%> (?)`
unit	`71.0249% <ø> (+0.0473%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`53.9663% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`48.3081% <0.0000%> (-4.7177%)`	⬇️

Signed-off-by: JmPotato <ghzpotato@gmail.com>

JmPotato · 2023-11-29T08:56:09Z

pkg/domain/infosync/info_test.go

@@ -279,43 +279,3 @@ func TestTiFlashManager(t *testing.T) {

 	CloseTiFlashManager(ctx)
 }
-
-func TestRuleOp(t *testing.T) {


Remove due to https://github.com/tikv/pd/pull/7462/files#diff-55223b29b1e0d97b9824b2bdf24c6f4a1b2b54bf408bb02182c06ffca8b8d0c3R52 and https://github.com/tikv/pd/pull/7462/files#diff-55223b29b1e0d97b9824b2bdf24c6f4a1b2b54bf408bb02182c06ffca8b8d0c3R114.

Signed-off-by: JmPotato <ghzpotato@gmail.com>

CabinfeverB · 2023-11-30T08:48:18Z

Sry, I will update client.go right now.

CabinfeverB · 2023-11-30T09:26:42Z

Maybe we should upgrade client go by tikv/client-go#1069, and try to pass all CI test. If pass, we can merge tikv/client-go#1069 by force

Signed-off-by: JmPotato <ghzpotato@gmail.com>

CabinfeverB · 2023-12-01T04:16:40Z

/test build

tiprow · 2023-12-01T04:17:00Z

@CabinfeverB: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

disksing · 2023-12-01T06:35:53Z

/merge

ti-chi-bot · 2023-12-01T06:35:56Z

@disksing: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-12-01T06:35:58Z

[LGTM Timeline notifier]

Timeline:

2023-12-01 05:45:20.027697668 +0000 UTC m=+1160748.692923861: ☑️ agreed by hawkingrei.
2023-12-01 06:35:56.824727196 +0000 UTC m=+1163785.489953390: ☑️ agreed by disksing.

GMHDBJD

LGTM

ti-chi-bot · 2023-12-01T08:12:26Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: disksing, GMHDBJD, hawkingrei, tangenta, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [GMHDBJD,YuJuncen,disksing,hawkingrei,tangenta]
~~br/OWNERS~~ [YuJuncen]
~~br/pkg/lightning/OWNERS~~ [GMHDBJD]
~~pkg/ddl/OWNERS~~ [tangenta]
~~pkg/domain/OWNERS~~ [GMHDBJD,tangenta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

JmPotato · 2023-12-01T11:09:05Z

/test unit-test

tiprow · 2023-12-01T11:09:17Z

@JmPotato: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Fully integrated PD HTTP client into InfoSyncer

72f3c32

Signed-off-by: JmPotato <ghzpotato@gmail.com>

ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 29, 2023

JmPotato mentioned this pull request Nov 29, 2023

Tracking issue for the HTTP SDK tikv/pd#7300

Open

7 tasks

Fix the InfoSyncer test

296a147

Signed-off-by: JmPotato <ghzpotato@gmail.com>

JmPotato force-pushed the adpot_client_to_info_syncer branch from d3f9843 to 296a147 Compare November 29, 2023 08:55

JmPotato commented Nov 29, 2023

View reviewed changes

Reduce the code

326330c

Signed-off-by: JmPotato <ghzpotato@gmail.com>

JmPotato force-pushed the adpot_client_to_info_syncer branch 3 times, most recently from 1a43944 to 2036b87 Compare November 30, 2023 10:26

Update the PD HTTP client version

77e05cd

Signed-off-by: JmPotato <ghzpotato@gmail.com>

JmPotato force-pushed the adpot_client_to_info_syncer branch from 2036b87 to 77e05cd Compare November 30, 2023 10:36

Update the client-go version

f8cf570

Signed-off-by: JmPotato <ghzpotato@gmail.com>

hawkingrei approved these changes Dec 1, 2023

View reviewed changes

ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 1, 2023

disksing approved these changes Dec 1, 2023

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 1, 2023

tangenta approved these changes Dec 1, 2023

View reviewed changes

GMHDBJD approved these changes Dec 1, 2023

View reviewed changes

YuJuncen approved these changes Dec 1, 2023

View reviewed changes

ti-chi-bot bot added the approved label Dec 1, 2023

ti-chi-bot bot merged commit 7353fbe into pingcap:master Dec 1, 2023
28 checks passed

JmPotato deleted the adpot_client_to_info_syncer branch December 1, 2023 11:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

infosync: fully integrated PD HTTP client into InfoSyncer #49006

infosync: fully integrated PD HTTP client into InfoSyncer #49006

JmPotato commented Nov 29, 2023 •

edited

Loading

codecov bot commented Nov 29, 2023 •

edited

Loading

JmPotato Nov 29, 2023 •

edited

Loading

CabinfeverB commented Nov 30, 2023

CabinfeverB commented Nov 30, 2023

CabinfeverB commented Dec 1, 2023

tiprow bot commented Dec 1, 2023

disksing commented Dec 1, 2023

ti-chi-bot bot commented Dec 1, 2023

ti-chi-bot bot commented Dec 1, 2023

GMHDBJD left a comment

ti-chi-bot bot commented Dec 1, 2023

JmPotato commented Dec 1, 2023

tiprow bot commented Dec 1, 2023

infosync: fully integrated PD HTTP client into InfoSyncer #49006

infosync: fully integrated PD HTTP client into InfoSyncer #49006

Conversation

JmPotato commented Nov 29, 2023 • edited Loading

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

codecov bot commented Nov 29, 2023 • edited Loading

Codecov Report

JmPotato Nov 29, 2023 • edited Loading

Choose a reason for hiding this comment

CabinfeverB commented Nov 30, 2023

CabinfeverB commented Nov 30, 2023

CabinfeverB commented Dec 1, 2023

tiprow bot commented Dec 1, 2023

disksing commented Dec 1, 2023

ti-chi-bot bot commented Dec 1, 2023

ti-chi-bot bot commented Dec 1, 2023

[LGTM Timeline notifier]

GMHDBJD left a comment

Choose a reason for hiding this comment

ti-chi-bot bot commented Dec 1, 2023

JmPotato commented Dec 1, 2023

tiprow bot commented Dec 1, 2023

JmPotato commented Nov 29, 2023 •

edited

Loading

codecov bot commented Nov 29, 2023 •

edited

Loading

JmPotato Nov 29, 2023 •

edited

Loading