-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: further adaptation to PD HTTP client #48606
Conversation
2fdc1df
to
9742489
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #48606 +/- ##
================================================
+ Coverage 71.0747% 72.9553% +1.8806%
================================================
Files 1365 1388 +23
Lines 404155 412403 +8248
================================================
+ Hits 287252 300870 +13618
+ Misses 96945 92734 -4211
+ Partials 19958 18799 -1159
Flags with carried forward coverage won't be shown. Click here to find out more.
|
2f23f66
to
4bcf93f
Compare
/test unit-test |
@JmPotato: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
482e97d
to
1faa049
Compare
/retest |
5d1c774
to
f2d3d82
Compare
Signed-off-by: JmPotato <ghzpotato@gmail.com>
Signed-off-by: JmPotato <ghzpotato@gmail.com>
Signed-off-by: JmPotato <ghzpotato@gmail.com>
f2d3d82
to
91eb4f0
Compare
Signed-off-by: JmPotato <ghzpotato@gmail.com>
91eb4f0
to
84d541c
Compare
[LGTM Timeline notifier]Timeline:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest lgtm
Signed-off-by: JmPotato <ghzpotato@gmail.com>
/retest-required |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, lichunzhu, tangenta, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: ref #35319, tikv/pd#7300. Should merge after tikv/pd#7371.
Problem Summary:
What is changed and how it works?
pkg/util/pdapi
package.Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.