Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: further adaptation to PD HTTP client #48606

Merged
merged 5 commits into from
Nov 20, 2023

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Nov 15, 2023

What problem does this PR solve?

Issue Number: ref #35319, tikv/pd#7300. Should merge after tikv/pd#7371.

Problem Summary:

What is changed and how it works?

  • Remove pkg/util/pdapi package.
  • Further integrate with the PD HTTP client.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 15, 2023
@JmPotato JmPotato force-pushed the adopt_to_pd_http_client branch from 2fdc1df to 9742489 Compare November 15, 2023 07:53
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Merging #48606 (5bc4574) into master (ab354f3) will increase coverage by 1.8806%.
Report is 14 commits behind head on master.
The diff coverage is 43.2000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #48606        +/-   ##
================================================
+ Coverage   71.0747%   72.9553%   +1.8806%     
================================================
  Files          1365       1388        +23     
  Lines        404155     412403      +8248     
================================================
+ Hits         287252     300870     +13618     
+ Misses        96945      92734      -4211     
+ Partials      19958      18799      -1159     
Flag Coverage Δ
integration 43.5562% <10.6557%> (?)
unit 71.3825% <43.2000%> (+0.3078%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9874% <ø> (ø)
parser ∅ <ø> (∅)
br 48.8869% <51.6129%> (-4.2184%) ⬇️

@JmPotato JmPotato force-pushed the adopt_to_pd_http_client branch from 2f23f66 to 4bcf93f Compare November 15, 2023 09:21
@JmPotato
Copy link
Member Author

/test unit-test

Copy link

tiprow bot commented Nov 15, 2023

@JmPotato: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JmPotato JmPotato force-pushed the adopt_to_pd_http_client branch from 482e97d to 1faa049 Compare November 15, 2023 10:28
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 15, 2023
@JmPotato
Copy link
Member Author

/retest

@JmPotato JmPotato force-pushed the adopt_to_pd_http_client branch from 5d1c774 to f2d3d82 Compare November 17, 2023 05:01
Signed-off-by: JmPotato <ghzpotato@gmail.com>
Signed-off-by: JmPotato <ghzpotato@gmail.com>
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato JmPotato force-pushed the adopt_to_pd_http_client branch from f2d3d82 to 91eb4f0 Compare November 17, 2023 05:02
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato JmPotato force-pushed the adopt_to_pd_http_client branch from 91eb4f0 to 84d541c Compare November 17, 2023 05:11
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 17, 2023
Copy link

ti-chi-bot bot commented Nov 17, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-15 13:26:46.911562709 +0000 UTC m=+4255604.498672855: ☑️ agreed by hawkingrei.
  • 2023-11-17 05:36:32.574340707 +0000 UTC m=+4400190.161450853: ☑️ agreed by tangenta.

Copy link
Contributor

@YuJuncen YuJuncen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

br/pkg/restore/split/client.go Outdated Show resolved Hide resolved
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato JmPotato requested a review from YuJuncen November 17, 2023 05:58
@JmPotato
Copy link
Member Author

/retest-required

Copy link

ti-chi-bot bot commented Nov 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, lichunzhu, tangenta, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 20, 2023
@ti-chi-bot ti-chi-bot bot merged commit 95759f4 into pingcap:master Nov 20, 2023
19 of 20 checks passed
@JmPotato JmPotato deleted the adopt_to_pd_http_client branch November 20, 2023 05:09
@JmPotato JmPotato restored the adopt_to_pd_http_client branch November 21, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants