client/http: implement more HTTP APIs #7371

JmPotato · 2023-11-15T07:11:07Z

What problem does this PR solve?

Issue Number: ref #7300.

What is changed and how does it work?

- Implement more HTTP APIs.
- Use consts more in `Rule` structure.

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)

Release note

None.

ti-chi-bot · 2023-11-15T07:11:10Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

HuSharp
rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

codecov · 2023-11-15T07:38:46Z

Codecov Report

Merging #7371 (6cef656) into master (f2eaf23) will increase coverage by 0.00%.
The diff coverage is 41.48%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #7371   +/-   ##
=======================================
  Coverage   74.28%   74.29%           
=======================================
  Files         451      451           
  Lines       48899    48967   +68     
=======================================
+ Hits        36327    36380   +53     
- Misses       9348     9369   +21     
+ Partials     3224     3218    -6

Flag	Coverage Δ
unittests	`74.29% <41.48%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

JmPotato · 2023-11-15T09:51:41Z

/cc @HuSharp @nolouch @CabinfeverB

client/http/client.go

rleungx · 2023-11-16T02:40:13Z

client/http/client.go

@@ -154,7 +159,7 @@ func (c *client) execDuration(name string, duration time.Duration) {
 // it consistent with the current implementation of some clients (e.g. TiDB).
 func (c *client) requestWithRetry(


Is it possible to customize the retry?

We will provide the function of custom backoffer in the future, but at present, the interface we are about to replace in TiDB uses this simple retry method.

I still prefer to leave it to the caller even if the retry method is simple.

Make sense to me though I'd like to implement it in an independent PR later.

HuSharp · 2023-11-16T05:08:41Z

client/http/client.go

+func (c *client) SetPlacementRule(ctx context.Context, rule *Rule) error {
+	ruleJSON, err := json.Marshal(rule)
+	if err != nil {
+		return errors.Trace(err)


not sure why needs errors.Trace?

One is to be consistent with the original HTTP call code of TiDB, and the other is that because it is a general library, adding trace information can help us better locate where the call is wrong I think.

HuSharp

LGTM!

Signed-off-by: JmPotato <ghzpotato@gmail.com>

JmPotato · 2023-11-17T04:07:19Z

/merge

ti-chi-bot · 2023-11-17T04:07:21Z

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-11-17T04:07:23Z

This pull request has been accepted and is ready to merge.

Commit hash: 6cef656

JmPotato added component/api HTTP API. component/client Client logic. labels Nov 15, 2023

ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Nov 15, 2023

ti-chi-bot bot requested a review from rleungx November 15, 2023 07:11

ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 15, 2023

JmPotato mentioned this pull request Nov 15, 2023

*: further adaptation to PD HTTP client pingcap/tidb#48606

Merged

3 tasks

ti-chi-bot bot requested review from CabinfeverB, HuSharp and nolouch November 15, 2023 09:51

HuSharp reviewed Nov 16, 2023

View reviewed changes

client/http/client.go Outdated Show resolved Hide resolved

HuSharp reviewed Nov 16, 2023

View reviewed changes

client/http/client.go Outdated Show resolved Hide resolved

HuSharp reviewed Nov 16, 2023

View reviewed changes

client/http/client.go Show resolved Hide resolved

rleungx reviewed Nov 16, 2023

View reviewed changes

JmPotato force-pushed the more_http_interfaces branch from 5d35dec to 8fbe931 Compare November 16, 2023 04:03

ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 16, 2023

JmPotato requested review from rleungx and HuSharp November 16, 2023 04:05

HuSharp reviewed Nov 16, 2023

View reviewed changes

JmPotato requested a review from HuSharp November 17, 2023 03:37

rleungx approved these changes Nov 17, 2023

View reviewed changes

ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 17, 2023

HuSharp approved these changes Nov 17, 2023

View reviewed changes

ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 17, 2023

JmPotato added 2 commits November 17, 2023 12:07

Implement more HTTP APIs

77f459e

Signed-off-by: JmPotato <ghzpotato@gmail.com>

Fix URL query escape for RegionStatsByStartEndKey

a7f5a17

Signed-off-by: JmPotato <ghzpotato@gmail.com>

JmPotato added 2 commits November 17, 2023 12:07

Add tests for the new interfaces

91a633c

Signed-off-by: JmPotato <ghzpotato@gmail.com>

Use consts more

6cef656

Signed-off-by: JmPotato <ghzpotato@gmail.com>

JmPotato force-pushed the more_http_interfaces branch from 8fbe931 to 6cef656 Compare November 17, 2023 04:07

ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 17, 2023

ti-chi-bot bot merged commit dda748a into tikv:master Nov 17, 2023
24 of 26 checks passed

JmPotato deleted the more_http_interfaces branch November 17, 2023 04:18

JmPotato mentioned this pull request Nov 21, 2023

Tracking issue for the HTTP SDK #7300

Open

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

client/http: implement more HTTP APIs #7371

client/http: implement more HTTP APIs #7371

JmPotato commented Nov 15, 2023 •

edited

Loading

ti-chi-bot bot commented Nov 15, 2023 •

edited

Loading

codecov bot commented Nov 15, 2023 •

edited

Loading

JmPotato commented Nov 15, 2023

rleungx Nov 16, 2023

JmPotato Nov 16, 2023

rleungx Nov 17, 2023

JmPotato Nov 17, 2023

HuSharp Nov 16, 2023

JmPotato Nov 16, 2023

HuSharp left a comment

JmPotato commented Nov 17, 2023

ti-chi-bot bot commented Nov 17, 2023

ti-chi-bot bot commented Nov 17, 2023

		@@ -154,7 +159,7 @@ func (c *client) execDuration(name string, duration time.Duration) {
		// it consistent with the current implementation of some clients (e.g. TiDB).
		func (c *client) requestWithRetry(

client/http: implement more HTTP APIs #7371

client/http: implement more HTTP APIs #7371

Conversation

JmPotato commented Nov 15, 2023 • edited Loading

What problem does this PR solve?

What is changed and how does it work?

Check List

Release note

ti-chi-bot bot commented Nov 15, 2023 • edited Loading

codecov bot commented Nov 15, 2023 • edited Loading

Codecov Report

JmPotato commented Nov 15, 2023

rleungx Nov 16, 2023

Choose a reason for hiding this comment

JmPotato Nov 16, 2023

Choose a reason for hiding this comment

rleungx Nov 17, 2023

Choose a reason for hiding this comment

JmPotato Nov 17, 2023

Choose a reason for hiding this comment

HuSharp Nov 16, 2023

Choose a reason for hiding this comment

JmPotato Nov 16, 2023

Choose a reason for hiding this comment

HuSharp left a comment

Choose a reason for hiding this comment

JmPotato commented Nov 17, 2023

ti-chi-bot bot commented Nov 17, 2023

ti-chi-bot bot commented Nov 17, 2023

JmPotato commented Nov 15, 2023 •

edited

Loading

ti-chi-bot bot commented Nov 15, 2023 •

edited

Loading

codecov bot commented Nov 15, 2023 •

edited

Loading