-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disttask/ddl: fail task for panic #48135
Conversation
Hi @ywqzzy. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #48135 +/- ##
================================================
+ Coverage 71.5999% 72.8447% +1.2447%
================================================
Files 1400 1423 +23
Lines 405985 412715 +6730
================================================
+ Hits 290685 300641 +9956
+ Misses 95492 93187 -2305
+ Partials 19808 18887 -921
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
@ywqzzy: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, wjhuang2016 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #48136
Problem Summary:
When operators for add index met some internal panic(possible when code have bugs or data corrupt), they will recover from panics since operators are running on workerpool.
Then the panics won't pass to the dist framework, then framework will mark subtasks which encountered panics as succeed.
What is changed and how it works?
Add recover for each operators of add index, cancel the pipeline when met panic.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.