Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disttask/ddl: fail task for panic (#48135) #48157

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #48135

What problem does this PR solve?

Issue Number: close #48136

Problem Summary:
When operators for add index met some internal panic(possible when code have bugs or data corrupt), they will recover from panics since operators are running on workerpool.
Then the panics won't pass to the dist framework, then framework will mark subtasks which encountered panics as succeed.

What is changed and how it works?

Add recover for each operators of add index, cancel the pipeline when met panic.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Nov 1, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 1, 2023
13 tasks
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 1, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Nov 1, 2023
Copy link

ti-chi-bot bot commented Nov 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tangenta, ywqzzy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 1, 2023
Copy link

ti-chi-bot bot commented Nov 1, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-01 05:52:11.215047507 +0000 UTC m=+3018728.802157652: ☑️ agreed by ywqzzy.
  • 2023-11-01 06:04:16.971146767 +0000 UTC m=+3019454.558256896: ☑️ agreed by tangenta.

@ti-chi-bot ti-chi-bot bot merged commit 1e4a9db into pingcap:release-7.5 Nov 1, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants