disttask/ddl: fail task for panic (#48135) #48157
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #48135
What problem does this PR solve?
Issue Number: close #48136
Problem Summary:
When operators for add index met some internal panic(possible when code have bugs or data corrupt), they will recover from panics since operators are running on workerpool.
Then the panics won't pass to the dist framework, then framework will mark subtasks which encountered panics as succeed.
What is changed and how it works?
Add recover for each operators of add index, cancel the pipeline when met panic.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.