planner: quick fix the panic issue when restoring hints from a plan (#48640) #48642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
added
ok-to-test
13 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-7.1 #48642 +/- ##
================================================
Coverage ? 73.7879%
================================================
Files ? 1206
Lines ? 380519
Branches ? 0
================================================
Hits ? 280777
Misses ? 82027
Partials ? 17715 |
ti-chi-bot
added
the
cherry-pick-approved
time-and-fate
approved these changes
Dec 1, 2023
ti-chi-bot
bot
added
needs-1-more-lgtm
AilinKid
approved these changes
Dec 4, 2023
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, time-and-fate The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
rleungx
pushed a commit
to rleungx/tidb
that referenced
this pull request
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #48640
What problem does this PR solve?
Issue Number: ref #46791
Problem Summary: planner: quick fix the panic issue when restoring hints from a plan
What is changed and how it works?
Forget to check whether the pointer is nil before using it:
But this pointer shouldn't be nil anyway, the root cause still needs more investigation, this is just a quick fix for users.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.