ddl: Unify drop table index and tiny clean up #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -190,14 +191,10 @@ func (d *ddl) delKeysWithPrefix(prefix kv.Key) error { | |||
| return nil | |||
| }) | |||
|
|
|||
| if err != nil { | |||
| // if err or delete no keys, returns. | |||
| if err != nil || len(keys) == 0 { | |||
There was a problem hiding this comment.
We should keep check err and value separately, like old code.
|
LGTM |
|
PTAL @siddontang |
|
No need to handle drop column data? |
|
@siddontang |
|
LGTM |
zimulala
added a commit
that referenced
this pull request
Jan 7, 2016
ddl: Unify drop table index and tiny clean up
xhebox
pushed a commit
to xhebox/tidb
that referenced
this pull request
Sep 28, 2021
* add auto_random table option support * . * .
xhebox
pushed a commit
to xhebox/tidb
that referenced
this pull request
Oct 8, 2021
* add auto_random table option support * . * .
ti-chi-bot
pushed a commit
that referenced
this pull request
Oct 9, 2021
* add auto_random table option support * . * .
rleungx
pushed a commit
to rleungx/tidb
that referenced
this pull request
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.