Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: Fix the panic in approx_percentile function #49644

Merged
merged 8 commits into from
Dec 29, 2023

Conversation

xzhangxian1008
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #40463

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed do-not-merge/invalid-title size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 21, 2023
Copy link

tiprow bot commented Dec 21, 2023

Hi @xzhangxian1008. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xzhangxian1008
Copy link
Contributor Author

/cc @SeaRise @XuHuaiyu @windtalker

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Merging #49644 (dab705f) into master (56bf775) will increase coverage by 0.1919%.
Report is 90 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #49644        +/-   ##
================================================
+ Coverage   70.9792%   71.1712%   +0.1919%     
================================================
  Files          1368       1430        +62     
  Lines        398687     430861     +32174     
================================================
+ Hits         282985     306649     +23664     
- Misses        95933     105041      +9108     
+ Partials      19769      19171       -598     
Flag Coverage Δ
integration 43.8977% <100.0000%> (?)
unit 70.9797% <ø> (+0.0004%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 45.8037% <ø> (-7.0727%) ⬇️

pkg/executor/aggfuncs/aggfunc_test.go Show resolved Hide resolved
pkg/executor/aggfuncs/builder.go Outdated Show resolved Hide resolved
@xzhangxian1008
Copy link
Contributor Author

/cc @SeaRise @windtalker

@ti-chi-bot ti-chi-bot bot requested a review from SeaRise December 22, 2023 01:01
Copy link
Contributor

@SeaRise SeaRise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM

@@ -57,3 +59,12 @@ func TestPercentile(t *testing.T) {
require.Equal(t, want, data[index])
}
}

func TestFix40463(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 22, 2023
Copy link

ti-chi-bot bot commented Dec 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guo-shaoge, SeaRise

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 27, 2023
Copy link

ti-chi-bot bot commented Dec 27, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-22 02:22:35.058740826 +0000 UTC m=+1186846.095967754: ☑️ agreed by SeaRise.
  • 2023-12-27 01:48:16.144480433 +0000 UTC m=+1616787.181707345: ☑️ agreed by guo-shaoge.

@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. labels Dec 29, 2023
@xzhangxian1008
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 29, 2023
@xzhangxian1008
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Dec 29, 2023

@xzhangxian1008: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit 4a47236 into pingcap:master Dec 29, 2023
16 of 17 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #49910.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 29, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #49911.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 29, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #49912.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 29, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.4: #49913.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 29, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #49914.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 29, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@xzhangxian1008 xzhangxian1008 deleted the fix-40463 branch December 29, 2023 07:21
ti-chi-bot bot pushed a commit that referenced this pull request Feb 4, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Mar 14, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parallel hash aggregation panicked
4 participants