-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: Fix the panic in approx_percentile
function (#49644)
#49910
executor: Fix the panic in approx_percentile
function (#49644)
#49910
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/open |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@xzhangxian1008: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/retest |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #49910 +/- ##
================================================
Coverage ? 73.6625%
================================================
Files ? 1095
Lines ? 350839
Branches ? 0
================================================
Hits ? 258437
Misses ? 75800
Partials ? 16602 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: windtalker, XuHuaiyu, xzhangxian1008 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This is an automated cherry-pick of #49644
What problem does this PR solve?
Issue Number: close #40463
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.