Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix show stats_bucket couldn't decode index boundary out (#49945) #49961

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #49945

What problem does this PR solve?

Issue Number: close #49823

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

planner: fix show stats_bucket couldn't decode index boundary out

Signed-off-by: AilinKid <314806019@qq.com>
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Jan 2, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jan 4, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 1, 2024
@AilinKid
Copy link
Contributor

AilinKid commented Feb 1, 2024

/test unit-test

Copy link

tiprow bot commented Feb 1, 2024

@AilinKid: No presubmit jobs available for pingcap/tidb@release-7.5

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

ti-chi-bot bot commented Feb 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@winoros
Copy link
Member

winoros commented Feb 1, 2024

/retest

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 1, 2024
Copy link

ti-chi-bot bot commented Feb 1, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-01 07:47:22.320622605 +0000 UTC m=+1638083.884920307: ☑️ agreed by AilinKid.
  • 2024-02-01 13:10:12.460179755 +0000 UTC m=+1657454.024477460: ☑️ agreed by winoros.

Signed-off-by: AilinKid <314806019@qq.com>
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-7.5@20c3e7d). Click here to learn what that means.
The diff coverage is 100.0000%.

❗ Current head 3b45243 differs from pull request most recent head 6b08fc7. Consider uploading reports for the commit 6b08fc7 to get more accurate results

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #49961   +/-   ##
================================================
  Coverage               ?   72.0036%           
================================================
  Files                  ?       1404           
  Lines                  ?     407764           
  Branches               ?          0           
================================================
  Hits                   ?     293605           
  Misses                 ?      94424           
  Partials               ?      19735           
Flag Coverage Δ
unit 72.0036% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.3104% <0.0000%> (?)

@winoros winoros force-pushed the cherry-pick-49945-to-release-7.5 branch from 3b45243 to 6b08fc7 Compare February 20, 2024 10:05
@wuhuizuo
Copy link
Contributor

/hold
wait for merging of #51164

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 20, 2024
@wuhuizuo
Copy link
Contributor

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 20, 2024
@ti-chi-bot ti-chi-bot bot merged commit 0a50f4c into pingcap:release-7.5 Feb 20, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants