Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix show stats_bucket couldn't decode index boundary out (#49945) #49961

Merged
merged 2 commits into from
Feb 20, 2024
Merged

planner: fix show stats_bucket couldn't decode index boundary out (#49945) #49961

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8bb2258
fix show stats_bucket couldn't decode boundary out
AilinKid Dec 30, 2023
6b08fc7
fix test
AilinKid Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions pkg/executor/show_stats_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,24 @@ func TestShowStatsBuckets(t *testing.T) {
result.Check(testkit.Rows("test t idx 1 0 1 1 (2020-01-01 00:00:00, 1) (2020-01-01 00:00:00, 1) 0"))
}

func TestShowStatsBucketWithDateNullValue(t *testing.T) {
store := testkit.CreateMockStore(t)
tk := testkit.NewTestKit(t, store)
tk.MustExec("use test")
tk.MustExec("drop table if exists t")
tk.MustExec("create table t(a datetime, b int, index ia(a,b));")
tk.MustExec("insert into t value('2023-12-27',1),(null, 2),('2023-12-28',3),(null,4);")
tk.MustExec("analyze table t with 0 topn;")
tk.MustQuery("explain format=\"brief\" select * from t where a > 1;").Check(testkit.Rows(
"IndexReader 3.20 root index:Selection",
"└─Selection 3.20 cop[tikv] gt(cast(test.t.a, double BINARY), 1)",
" └─IndexFullScan 4.00 cop[tikv] table:t, index:ia(a, b) keep order:false"))
tk.MustQuery("show stats_buckets where db_name = 'test' and Column_name = 'ia';").Check(testkit.Rows(
"test t ia 1 0 1 1 (NULL, 4) (NULL, 4) 0",
"test t ia 1 1 2 1 (2023-12-27 00:00:00, 1) (2023-12-27 00:00:00, 1) 0",
"test t ia 1 2 3 1 (2023-12-28 00:00:00, 3) (2023-12-28 00:00:00, 3) 0"))
}

func TestShowStatsHasNullValue(t *testing.T) {
store := testkit.CreateMockStore(t)

Expand Down
3 changes: 3 additions & 0 deletions pkg/util/codec/codec.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -889,6 +889,9 @@ func DecodeAsDateTime(b []byte, tp byte, loc *time.Location) (remain []byte, d t
case uvarintFlag:
// Datetime can be encoded as Uvarint
b, v, err = DecodeUvarint(b)
case NilFlag:
// null value should also be decoded out.
return b, d, nil

default:
return b, d, errors.Errorf("invalid encoded key flag %v", flag)
Expand Down