Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightning: remove alter table lock #50074

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

D3Hunter
Copy link
Contributor

@D3Hunter D3Hunter commented Jan 4, 2024

What problem does this PR solve?

Issue Number: close #50105

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    import large mount of tables(each table is about several tens of MB), after this pr, we can import from 674 tables/h/instance -> 809. Since TiDB still handle alter table in serial internally, the speedup is not that obvious. Note we are importing using 10 lightning, some instance have more improvement
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/invalid-title do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 4, 2024
@D3Hunter D3Hunter changed the title [WIP] remove alter table log & remove limit on region-concurrency [WIP] remove alter table lock & remove limit on region-concurrency Jan 4, 2024
Copy link

tiprow bot commented Jan 4, 2024

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Merging #50074 (d563285) into master (6f32664) will increase coverage by 10.5483%.
Report is 16 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #50074         +/-   ##
=================================================
+ Coverage   71.8820%   82.4304%   +10.5483%     
=================================================
  Files          1439       2444       +1005     
  Lines        346160     673313     +327153     
=================================================
+ Hits         248827     555015     +306188     
- Misses        77058      97285      +20227     
- Partials      20275      21013        +738     
Flag Coverage Δ
integration 50.3180% <ø> (?)
unit 79.2725% <ø> (+7.3904%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 73.6130% <ø> (+17.3001%) ⬆️
parser ∅ <ø> (∅)
br 75.2542% <ø> (+23.7952%) ⬆️

@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked labels Jan 5, 2024
@D3Hunter D3Hunter changed the title [WIP] remove alter table lock & remove limit on region-concurrency lightning: remove alter table lock & remove limit on region-concurrency Jan 5, 2024
@ti-chi-bot ti-chi-bot bot removed do-not-merge/invalid-title do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jan 5, 2024
@D3Hunter D3Hunter changed the title lightning: remove alter table lock & remove limit on region-concurrency lightning: remove alter table lock Jan 5, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 5, 2024
@D3Hunter
Copy link
Contributor Author

D3Hunter commented Jan 5, 2024

/test pull-lightning-integration-test

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Jan 5, 2024

/hold

to wait lightning ci

Copy link

tiprow bot commented Jan 5, 2024

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-lightning-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 5, 2024
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Jan 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 5, 2024
Copy link

ti-chi-bot bot commented Jan 5, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-05 03:40:44.830046269 +0000 UTC m=+2401135.867273181: ☑️ agreed by lance6716.
  • 2024-01-05 03:42:48.328448651 +0000 UTC m=+2401259.365675577: ☑️ agreed by Benjamin2037.

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Jan 5, 2024

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 5, 2024
@ti-chi-bot ti-chi-bot bot merged commit b13d1d0 into pingcap:master Jan 5, 2024
29 of 37 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #50116.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jan 5, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #50117.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jan 5, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #50118.

@D3Hunter D3Hunter deleted the fix-serial-alter branch January 5, 2024 05:50
AilinKid pushed a commit to AilinKid/tidb that referenced this pull request Jan 17, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Jan 24, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Feb 2, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove alter table lock to improve performance when importing large mount of tables
4 participants