-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lightning: remove alter table lock (#50074) #50116
lightning: remove alter table lock (#50074) #50116
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: D3Hunter, okJiang, zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #50116 +/- ##
================================================
Coverage ? 73.7318%
================================================
Files ? 1094
Lines ? 351798
Branches ? 0
================================================
Hits ? 259387
Misses ? 75834
Partials ? 16577 |
This is an automated cherry-pick of #50074
What problem does this PR solve?
Issue Number: close #50105
Problem Summary:
What changed and how does it work?
Check List
Tests
import large mount of tables(each table is about several tens of MB), after this pr, we can import from 674 tables/h/instance -> 809. Since TiDB still handle
alter table
in serial internally, the speedup is not that obvious. Note we are importing using 10 lightning, some instance have more improvementSide effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.