-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: use fgprof to show off-CPU profile in external package #50179
Conversation
Signed-off-by: lance6716 <lance6716@gmail.com>
Hi @lance6716. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #50179 +/- ##
=================================================
- Coverage 79.3015% 67.2400% -12.0616%
=================================================
Files 2447 2571 +124
Lines 673721 843187 +169466
=================================================
+ Hits 534271 566959 +32688
- Misses 118049 252392 +134343
- Partials 21401 23836 +2435
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: lance6716 <lance6716@gmail.com>
Signed-off-by: lance6716 <lance6716@gmail.com>
/cc @Leavrth |
heapProfDoneCh = make(chan struct{}) | ||
heapWg.Add(1) | ||
go func() { | ||
defer heapWg.Done() | ||
|
||
var m runtime.MemStats | ||
ticker := time.NewTicker(300 * time.Millisecond) | ||
defer ticker.Stop() | ||
|
||
for { | ||
select { | ||
case <-heapProfDoneCh: | ||
return | ||
case <-ticker.C: | ||
runtime.ReadMemStats(&m) | ||
if m.HeapInuse <= maxInUse { | ||
continue | ||
} | ||
maxInUse = m.HeapInuse | ||
file, err2 := os.Create(filenameHeap) | ||
intest.AssertNoError(err2) | ||
err = pprof.WriteHeapProfile(file) | ||
intest.AssertNoError(err) | ||
err = file.Close() | ||
intest.AssertNoError(err) | ||
} | ||
} | ||
}() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrap a function?
Rest LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: D3Hunter, Leavrth, ywqzzy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: ref #48952
Problem Summary:
What changed and how does it work?
also upgrade the ks3 SDK
Check List
Tests
we can see network IO is shown in CPU flame graph
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.