-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: use another way to get index uniqueness during task exec init #50378
Conversation
Hi @tangenta. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #50378 +/- ##
=================================================
- Coverage 70.0238% 55.5905% -14.4333%
=================================================
Files 1444 1556 +112
Lines 419997 587796 +167799
=================================================
+ Hits 294098 326759 +32661
- Misses 105570 238319 +132749
- Partials 20329 22718 +2389
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm if existing integration test can cover this
go.mod
Outdated
@@ -69,7 +69,7 @@ require ( | |||
github.com/joho/sqltocsv v0.0.0-20210428211105-a6d6801d59df | |||
github.com/kisielk/errcheck v1.6.3 | |||
github.com/klauspost/compress v1.17.1 | |||
github.com/ks3sdklib/aws-sdk-go v1.2.9 | |||
github.com/ks3sdklib/aws-sdk-go v1.2.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why? we just upgrade it. #50179
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a network problem with ks3 Read()
. I want to make a quick test by downgrading it.
This reverts commit f8051c5.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[LGTM Timeline notifier]Timeline:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, D3Hunter, ywqzzy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
What problem does this PR solve?
Issue Number: ref #50307, close #50435
What changed and how does it work?
This PR fixes the stuck issue cause by
indexInfo not found
when cancelling the task.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.