Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: use another way to get index uniqueness during task exec init (#50378) #50452

Merged
merged 3 commits into from
Feb 20, 2024
Merged

ddl: use another way to get index uniqueness during task exec init (#50378) #50452

merged 3 commits into from
Feb 20, 2024

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #50378

What problem does this PR solve?

Issue Number: ref #50307, close #50435

What changed and how does it work?

This PR fixes the stuck issue cause by indexInfo not found when cancelling the task.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@tangenta @ti-chi-bot
This is an automated cherry-pick of pingcap#50378
eee00b9 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Jan 16, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 16, 2024
Merged
13 tasks
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 16, 2024
Benjamin2037
Benjamin2037 approved these changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 17, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 1, 2024
D3Hunter
D3Hunter approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@D3Hunter D3Hunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix conflict before merge

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 20, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-17 07:19:46.859962144 +0000 UTC m=+340428.424259850: ☑️ agreed by Benjamin2037.
  • 2024-02-20 02:18:11.037223907 +0000 UTC m=+323579.784847015: ☑️ agreed by D3Hunter.

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 20, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 20, 2024 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release-7.5@245dd62). Click here to learn what that means.
The diff coverage is 14.2857%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-7.5     #50452   +/-   ##
================================================
  Coverage               ?   72.4786%           
================================================
  Files                  ?       1404           
  Lines                  ?     410652           
  Branches               ?          0           
================================================
  Hits                   ?     297635           
  Misses                 ?      93407           
  Partials               ?      19610
Flag Coverage Δ
unit 72.4786% <14.2857%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.4001% <0.0000%> (?)

@tangenta tangenta force-pushed the cherry-pick-50378-to-release-7.5 branch 2 times, most recently from 7fdaa14 to fc0bfff Compare February 20, 2024 05:58
@tangenta tangenta force-pushed the cherry-pick-50378-to-release-7.5 branch from fc0bfff to ed231a3 Compare February 20, 2024 05:58
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, D3Hunter

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 20, 2024
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 20, 2024
@Benjamin2037
Copy link
Collaborator

/retest

@wuhuizuo
Copy link
Contributor

/hold
wait for merging of #51164

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 20, 2024
@wuhuizuo
Copy link
Contributor

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 20, 2024
@ti-chi-bot ti-chi-bot bot merged commit e67db56 into pingcap:release-7.5 Feb 20, 2024
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes

@D3Hunter D3Hunter D3Hunter approved these changes

Assignees

@tangenta tangenta

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-chi-bot @Benjamin2037 @wuhuizuo @D3Hunter @tangenta