Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

driver: convert ErrQueryInterrupted to actual error types #50517

Merged
merged 8 commits into from
Feb 5, 2024

Conversation

ekexium
Copy link
Contributor

@ekexium ekexium commented Jan 17, 2024

What problem does this PR solve?

Issue Number: ref #49643

Problem Summary:

When a kill signal is sent to client, and client interrupts. The error returned is a ErrQueryInterrupted. TiDB needs to convert it into concrete types.

What changed and how does it work?

Check List

Tests

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 17, 2024
Copy link

tiprow bot commented Jan 17, 2024

Hi @ekexium. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ekexium ekexium force-pushed the interrupted-error-with-signal branch from fad4165 to 052e0f4 Compare January 18, 2024 03:07
Signed-off-by: ekexium <eke@fastmail.com>
@ekexium ekexium force-pushed the interrupted-error-with-signal branch from 052e0f4 to 50aae2e Compare January 18, 2024 05:33
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 18, 2024
@ekexium
Copy link
Contributor Author

ekexium commented Jan 18, 2024

/retest

Copy link

tiprow bot commented Jan 18, 2024

@ekexium: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ekexium ekexium removed needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Jan 29, 2024
Signed-off-by: ekexium <eke@fastmail.com>
…or-with-signal

Signed-off-by: ekexium <eke@fastmail.com>
Signed-off-by: ekexium <eke@fastmail.com>
@ekexium ekexium force-pushed the interrupted-error-with-signal branch from 0047c36 to 9bd7f36 Compare January 29, 2024 09:13
@ekexium
Copy link
Contributor Author

ekexium commented Jan 29, 2024

/retest

Copy link

tiprow bot commented Jan 29, 2024

@ekexium: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: ekexium <eke@fastmail.com>
@ekexium ekexium force-pushed the interrupted-error-with-signal branch from 9bd7f36 to 871f142 Compare January 29, 2024 09:31
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Merging #50517 (792122b) into master (aa00ae2) will increase coverage by 1.6530%.
The diff coverage is 46.1538%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #50517        +/-   ##
================================================
+ Coverage   70.5606%   72.2136%   +1.6530%     
================================================
  Files          1466       1468         +2     
  Lines        434758     447112     +12354     
================================================
+ Hits         306768     322876     +16108     
+ Misses       108716     103822      -4894     
- Partials      19274      20414      +1140     
Flag Coverage Δ
integration 27.9133% <15.3846%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.2940% <ø> (ø)
parser ∅ <ø> (∅)
br 51.1523% <ø> (+5.4055%) ⬆️

@ekexium
Copy link
Contributor Author

ekexium commented Jan 29, 2024

/test unit-test

Copy link

tiprow bot commented Jan 29, 2024

@ekexium: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 5, 2024
@ekexium ekexium force-pushed the interrupted-error-with-signal branch from 93b3150 to 792122b Compare February 5, 2024 05:03
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 5, 2024
@ekexium ekexium removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Feb 5, 2024
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Feb 5, 2024
@ekexium ekexium removed the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Feb 5, 2024
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Feb 5, 2024
@ekexium
Copy link
Contributor Author

ekexium commented Feb 5, 2024

/retest

Copy link

tiprow bot commented Feb 5, 2024

@ekexium: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ekexium
Copy link
Contributor Author

ekexium commented Feb 5, 2024

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Feb 5, 2024
@ti-chi-bot ti-chi-bot bot merged commit 1621e0f into pingcap:master Feb 5, 2024
23 checks passed
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Feb 5, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #50979.

@ekexium ekexium deleted the interrupted-error-with-signal branch February 5, 2024 06:31
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Feb 26, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Feb 26, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #51318.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants