Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: fix br integration test 6.5.8 #50740

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

Leavrth
Copy link
Contributor

@Leavrth Leavrth commented Jan 26, 2024

What problem does this PR solve?

Issue Number: close #50741

Problem Summary:
br integration test bug

What changed and how does it work?

fix br integration test: match the correct error string

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 26, 2024
Copy link

tiprow bot commented Jan 26, 2024

Hi @Leavrth. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Leavrth
Copy link
Contributor Author

Leavrth commented Jan 26, 2024

/test pull-br-integration-test

Copy link

tiprow bot commented Jan 26, 2024

@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jan 26, 2024
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@6fc4f4d). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #50740   +/-   ##
================================================
  Coverage               ?   73.6294%           
================================================
  Files                  ?       1094           
  Lines                  ?     350611           
  Branches               ?          0           
================================================
  Hits                   ?     258153           
  Misses                 ?      75875           
  Partials               ?      16583           

@BornChanger BornChanger mentioned this pull request Jan 26, 2024
13 tasks

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth
Copy link
Contributor Author

Leavrth commented Jan 26, 2024

/test pull-br-integration-test

Copy link

tiprow bot commented Jan 26, 2024

@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 26, 2024
Copy link

ti-chi-bot bot commented Jan 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, BornChanger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 26, 2024
Copy link

ti-chi-bot bot commented Jan 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-26 02:38:37.121090911 +0000 UTC m=+1101158.685388617: ☑️ agreed by 3pointer.
  • 2024-01-26 03:24:22.981144864 +0000 UTC m=+1103904.545442564: ☑️ agreed by BornChanger.

@Leavrth
Copy link
Contributor Author

Leavrth commented Jan 26, 2024

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Jan 26, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jan 26, 2024
@ti-chi-bot ti-chi-bot bot merged commit 44f39e9 into pingcap:release-6.5 Jan 26, 2024
23 checks passed
@Leavrth Leavrth added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Mar 1, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #51438.

@Leavrth
Copy link
Contributor Author

Leavrth commented Mar 1, 2024

/cherry-pick-release-7.1

ti-chi-bot bot pushed a commit that referenced this pull request Mar 1, 2024
close #50741
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants