Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: fix br integration test 7.1.1 (#50740) #51438

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #50740

What problem does this PR solve?

Issue Number: close #50741

Problem Summary:
br integration test bug

What changed and how does it work?

fix br integration test: match the correct error string

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Leavrth added 2 commits March 1, 2024 02:04
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 1, 2024
13 tasks
@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Mar 1, 2024
@Leavrth
Copy link
Contributor

Leavrth commented Mar 1, 2024

/test pull-br-integration-test

Copy link

tiprow bot commented Mar 1, 2024

@Leavrth: No presubmit jobs available for pingcap/tidb@release-7.1

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 1, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Mar 1, 2024
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-7.1@503bf72). Click here to learn what that means.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.1     #51438   +/-   ##
================================================
  Coverage               ?   73.4245%           
================================================
  Files                  ?       1212           
  Lines                  ?     379474           
  Branches               ?          0           
================================================
  Hits                   ?     278627           
  Misses                 ?      83057           
  Partials               ?      17790           

Copy link

ti-chi-bot bot commented Mar 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 1, 2024
Copy link

ti-chi-bot bot commented Mar 1, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-01 02:10:00.15522622 +0000 UTC m=+1187088.902849333: ☑️ agreed by BornChanger.
  • 2024-03-01 02:39:12.480452251 +0000 UTC m=+1188841.228075377: ☑️ agreed by YuJuncen.

@ti-chi-bot ti-chi-bot bot merged commit 53abcef into pingcap:release-7.1 Mar 1, 2024
21 of 25 checks passed
@Leavrth Leavrth changed the title br: fix br integration test 6.5.8 (#50740) br: fix br integration test 7.1.1 (#50740) Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants