pkg/autoid_service: add lock to make API thread-safe

[tiancaiamao]

What problem does this PR solve?

Issue Number: close #50819

Problem Summary:

What changed and how does it work?

The exposed API should be thread-safe, and forceRebase allocAutoID alloc4Unsigned alloc4Signed ... all those internal functions should be called under lock.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @tiancaiamao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #50820 (45b5b09) into master (ff050bb) will increase coverage by 2.4664%.
Report is 17 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #50820        +/-   ##
================================================
+ Coverage   70.5750%   73.0414%   +2.4664%     
================================================
  Files          1463       1466         +3     
  Lines        433255     438466      +5211     
================================================
+ Hits         305770     320262     +14492     
+ Misses       108339      98414      -9925     
- Partials      19146      19790       +644     

Flag	Coverage Δ
integration	49.3922% <100.0000%> (?)
unit	70.6178% <100.0000%> (+0.2288%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	54.2940% <ø> (ø)
parser	∅ <ø> (∅)
br	51.5002% <ø> (+5.7111%)	⬆️

[bb7133]

What is the expected performance impact since we're using locks in wider scope.

Could you provide some kind of benchmark result, if possible?

[tiancaiamao]

For the AllocID API, I think it's almost the same with before, because the old code did use lock here too ... the only difference is req.N == 0 code branch which means a "get current autoid value" query.

For the Rebase API, the performance could be worse than before, but this query is rare comparing to the AllocID API, so the performance is not as sensitive.

From my experience data, simple insert into SQL query on AUTO_ID_CACHE=1 tables workload on my local machine get 140K QPS, and the AllocID API itself performs better than that. @bb7133

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/autoid_service/OWNERS [bb7133]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-01-30 09:45:56.317054261 +0000 UTC m=+1472397.881351968: ☑️ agreed by bb7133.
• 2024-01-31 04:21:58.40377274 +0000 UTC m=+1539359.968070429: ☑️ agreed by hawkingrei.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.5: #50892.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.1: #51322.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-6.5: #52059.