Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/autoid_service: add lock to make API thread-safe (#50820) #52059

Merged
merged 2 commits into from
Mar 28, 2024
Merged

pkg/autoid_service: add lock to make API thread-safe (#50820) #52059

merged 2 commits into from
Mar 28, 2024

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #50820

What problem does this PR solve?

Issue Number: close #50819

Problem Summary:

What changed and how does it work?

The exposed API should be thread-safe, and forceRebase allocAutoID alloc4Unsigned alloc4Signed ... all those internal functions should be called under lock.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@tiancaiamao @ti-chi-bot
This is an automated cherry-pick of pingcap#50820
0132822 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Mar 25, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 25, 2024
Merged
13 tasks
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Mar 25, 2024
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 25, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Mar 28, 2024
@tiancaiamao
Copy link
Contributor

/test mysql-test

@tiprow tiprow
Copy link

tiprow bot commented Mar 28, 2024

@tiancaiamao: No presubmit jobs available for pingcap/tidb@release-6.5

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov Codecov
Copy link

codecov bot commented Mar 28, 2024 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@efd2fab). Click here to learn what that means.
The diff coverage is 87.5000%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-6.5     #52059   +/-   ##
================================================
  Coverage               ?   73.6955%           
================================================
  Files                  ?       1096           
  Lines                  ?     351803           
  Branches               ?          0           
================================================
  Hits                   ?     259263           
  Misses                 ?      75911           
  Partials               ?      16629

bb7133
bb7133 approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 28, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 28, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-28 08:08:08.062302218 +0000 UTC m=+2141715.084548601: ☑️ agreed by hawkingrei.
  • 2024-03-28 17:49:42.64040732 +0000 UTC m=+2176609.662653709: ☑️ agreed by bb7133.

@ti-chi-bot ti-chi-bot bot merged commit 77d5317 into pingcap:release-6.5 Mar 28, 2024
10 checks passed
mittalrishabh pushed a commit to mittalrishabh/tidb that referenced this pull request May 30, 2024
@ti-chi-bot
pkg/autoid_service: add lock to make API thread-safe (pingcap#50820) (p…
1c01241 
…ingcap#52059) (pingcap#95)

close pingcap#50819

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@bb7133 bb7133 bb7133 approved these changes

Assignees

@tiancaiamao tiancaiamao

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @tiancaiamao @bb7133 @hawkingrei