Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix negative consumedbyte for hashRowcontainer #50843

Merged

Conversation

wshwsh12
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #50841

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix the issue that goroutine leak when hashJoin triggered spill and sql failed

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 31, 2024
Copy link

tiprow bot commented Jan 31, 2024

Hi @wshwsh12. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. and removed do-not-merge/needs-triage-completed labels Jan 31, 2024
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Merging #50843 (5d55642) into master (4e41699) will increase coverage by 0.4699%.
Report is 11 commits behind head on master.
The diff coverage is 50.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #50843        +/-   ##
================================================
+ Coverage   72.2282%   72.6981%   +0.4699%     
================================================
  Files          1465       1466         +1     
  Lines        360597     435473     +74876     
================================================
+ Hits         260453     316581     +56128     
- Misses        80883      99011     +18128     
- Partials      19261      19881       +620     
Flag Coverage Δ
integration 49.2368% <50.0000%> (?)
unit 70.3535% <50.0000%> (-1.7553%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.2940% <ø> (-2.1832%) ⬇️
parser ∅ <ø> (∅)
br 51.3913% <ø> (+5.1434%) ⬆️

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 31, 2024
Copy link

ti-chi-bot bot commented Jan 31, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-31 07:48:53.060011797 +0000 UTC m=+1551774.624309503: ☑️ agreed by XuHuaiyu.
  • 2024-01-31 09:14:42.978148252 +0000 UTC m=+1556924.542445942: ☑️ agreed by guo-shaoge.

@bb7133 bb7133 changed the title exeuctor: fix negative consumedbyte for hashRowcontainer executor: fix negative consumedbyte for hashRowcontainer Jan 31, 2024
Copy link

ti-chi-bot bot commented Jan 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, guo-shaoge, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [AilinKid,XuHuaiyu,guo-shaoge]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit acd4999 into pingcap:master Jan 31, 2024
23 checks passed
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Feb 2, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #50934.

@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. labels Feb 20, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #51189.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #51190.

@wshwsh12
Copy link
Contributor Author

/cherry-pick release-6.5-20231229-v6.5.6

@ti-chi-bot
Copy link
Member

@wshwsh12: new pull request created to branch release-6.5-20231229-v6.5.6: #53344.

In response to this:

/cherry-pick release-6.5-20231229-v6.5.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Goroutine leak when hashJoin triggered spill and sql failed.
5 participants