Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br/streamhelper: fix panic while removing task #50869

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

YuJuncen
Copy link
Contributor

@YuJuncen YuJuncen commented Feb 1, 2024

What problem does this PR solve?

Issue Number: close #50839

Problem Summary:

What changed and how does it work?

This PR will do the nil check over the checkpoints.
This PR also will catch the panic generated during the subscription handler.
And some locking are acquired during handling incoming tasks.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fixed a bug that may make TiDB panic when stopping a log backup task.

Signed-off-by: Yu Juncen <yu745514916@live.com>
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 1, 2024
Copy link

tiprow bot commented Feb 1, 2024

Hi @YuJuncen. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Merging #50869 (3065aa8) into master (c0476a0) will increase coverage by 5.4023%.
Report is 96 commits behind head on master.
The diff coverage is 79.4117%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #50869        +/-   ##
================================================
+ Coverage   70.3642%   75.7665%   +5.4022%     
================================================
  Files          1456       1464         +8     
  Lines        420924     442599     +21675     
================================================
+ Hits         296180     335342     +39162     
+ Misses       104409      87203     -17206     
+ Partials      20335      20054       -281     
Flag Coverage Δ
integration 50.2391% <29.4117%> (?)
unit 70.3082% <79.4117%> (-0.0376%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0269% <ø> (ø)
parser ∅ <ø> (∅)
br 56.0622% <79.4117%> (+5.4930%) ⬆️

@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Feb 1, 2024
Signed-off-by: Yu Juncen <yu745514916@live.com>
@YuJuncen
Copy link
Contributor Author

YuJuncen commented Feb 1, 2024

/retest-required

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 2, 2024
Copy link

ti-chi-bot bot commented Feb 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, Leavrth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 7, 2024
Copy link

ti-chi-bot bot commented Feb 7, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-02 06:02:33.126084619 +0000 UTC m=+1718194.690382324: ☑️ agreed by Leavrth.
  • 2024-02-07 08:33:15.967430327 +0000 UTC m=+345721.534200202: ☑️ agreed by BornChanger.

@ti-chi-bot ti-chi-bot bot merged commit 00f99ab into pingcap:master Feb 7, 2024
32 of 38 checks passed
@YuJuncen
Copy link
Contributor Author

YuJuncen commented Feb 7, 2024

/run-cherry-picker

@YuJuncen YuJuncen added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Feb 7, 2024
@YuJuncen
Copy link
Contributor Author

YuJuncen commented Feb 7, 2024

/run-cherry-picker

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #51052.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Feb 7, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #51053.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Feb 7, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #51054.

YuJuncen added a commit to YuJuncen/tidb that referenced this pull request Feb 18, 2024
close pingcap#50839

Signed-off-by: Yu Juncen <yu745514916@live.com>
BornChanger pushed a commit to BornChanger/tidb that referenced this pull request Feb 26, 2024
YuJuncen pushed a commit to ti-chi-bot/tidb that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

log_backup: TiDB may panic when canceling task.
5 participants