-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br/streamhelper: fix panic while removing task #50869
Conversation
Signed-off-by: Yu Juncen <yu745514916@live.com>
Hi @YuJuncen. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #50869 +/- ##
================================================
+ Coverage 70.3642% 75.7665% +5.4022%
================================================
Files 1456 1464 +8
Lines 420924 442599 +21675
================================================
+ Hits 296180 335342 +39162
+ Misses 104409 87203 -17206
+ Partials 20335 20054 -281
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/ok-to-test |
Signed-off-by: Yu Juncen <yu745514916@live.com>
/retest-required |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BornChanger, Leavrth The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/run-cherry-picker |
/run-cherry-picker |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
close pingcap#50839 Signed-off-by: Yu Juncen <yu745514916@live.com>
…ap#51305) Signed-off-by: Yu Juncen <yu745514916@live.com>
What problem does this PR solve?
Issue Number: close #50839
Problem Summary:
What changed and how does it work?
This PR will do the nil check over the
checkpoints
.This PR also will catch the panic generated during the subscription handler.
And some locking are acquired during handling incoming tasks.
Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.