-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br/streamhelper: fix panic while removing task (#50869) #51053
br/streamhelper: fix panic while removing task (#50869) #51053
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: Yu Juncen <yu745514916@live.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #51053 +/- ##
================================================
Coverage ? 71.9876%
================================================
Files ? 1403
Lines ? 407363
Branches ? 0
================================================
Hits ? 293251
Misses ? 94385
Partials ? 19727
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BornChanger, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
|
||
go func() { | ||
defer utils.CatchAndLogPanic() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if it catch the panic here. but this goroutine has no longer exists anymore.
do we need generate this for loop again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a random panic happens, the caller may or may not require retry this loop. I think it will be better to don't regenerate this loop and make the caller to decide whether to spawn another loop.
Perhaps we can add some mark about whether the goroutine is still running later. Anyhow that is out of this PR's scope, which focus on restricting the panic in the scope of log backup advancer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM
/retest-required |
/retest |
This is an automated cherry-pick of #50869
What problem does this PR solve?
Issue Number: close #50839
Problem Summary:
What changed and how does it work?
This PR will do the nil check over the
checkpoints
.This PR also will catch the panic generated during the subscription handler.
And some locking are acquired during handling incoming tasks.
Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.