ddl: table meta should store column without db and table name

[lcwangchao]

What problem does this PR solve?

Issue Number: close #50972

What changed and how does it work?

When storing an expression in table meta, the column name should be restored without db and table name to make sure the meta is still valid after renaming a table.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

fix a issue that some DDL will hang in some some cases.

[tiprow]

Hi @lcwangchao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #50978 (849103c) into master (aa00ae2) will increase coverage by 2.0834%.
Report is 3 commits behind head on master.
The diff coverage is 57.1428%.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #50978        +/-   ##
================================================
+ Coverage   70.5650%   72.6484%   +2.0834%     
================================================
  Files          1466       1466                
  Lines        434758     434871       +113     
================================================
+ Hits         306787     315927      +9140     
+ Misses       108704      98980      -9724     
- Partials      19267      19964       +697     

Flag	Coverage Δ
integration	49.0020% <50.0000%> (?)
unit	70.2941% <57.1428%> (-0.0814%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	54.2940% <ø> (ø)
parser	∅ <ø> (∅)
br	51.2026% <ø> (+5.4558%)	⬆️

[zimulala]

Could we modify RewriteSimpleExprWithTableInfo directly? RewriteSimpleExprWithTableInfo is used in one other place besides here, can that place be changed in the same way? This will remove the duplicate code here.

[lcwangchao]

I will refactor those expression methods later in another PR. We can just make it a quick fix for this issue.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fzzf678, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [zimulala]
• pkg/ddl/OWNERS [zimulala]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-02-05 07:02:15.964448823 +0000 UTC m=+167461.531218713: ☑️ agreed by fzzf678.
• 2024-02-05 07:20:40.632295892 +0000 UTC m=+168566.199065779: ☑️ agreed by zimulala.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.5: #51018.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-6.5: #51019.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.1: #51020.