-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
util/ranger: do not convert to binary collate for string values when convertToSortKey
is false
#51363
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51363 +/- ##
================================================
+ Coverage 70.5756% 72.6972% +2.1215%
================================================
Files 1462 1461 -1
Lines 434885 435516 +631
================================================
+ Hits 306923 316608 +9685
+ Misses 108661 98973 -9688
- Partials 19301 19935 +634
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tangenta, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #51316, close #51196
Problem Summary:
As said in 3. of #48522,
convertStringFTToBinaryCollate
should be used only for the newconvertToSortKey
case.But in the code, among the 4 places
convertStringFTToBinaryCollate
is called, 2 of them missed this check, and resulted in values with wrong types in the resultRange
.Currently
convertToSortKey = false
is only used for partition pruning.What changed and how does it work?
As the title says, add check for
convertToSortKey
when usingconvertStringFTToBinaryCollate
.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.