Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util/ranger: do not convert to binary collate for string values when convertToSortKey is false #51363

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

time-and-fate
Copy link
Member

@time-and-fate time-and-fate commented Feb 27, 2024

What problem does this PR solve?

Issue Number: close #51316, close #51196

Problem Summary:

As said in 3. of #48522, convertStringFTToBinaryCollate should be used only for the new convertToSortKey case.

But in the code, among the 4 places convertStringFTToBinaryCollate is called, 2 of them missed this check, and resulted in values with wrong types in the result Range.

Currently convertToSortKey = false is only used for partition pruning.

What changed and how does it work?

As the title says, add check for convertToSortKey when using convertStringFTToBinaryCollate.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 27, 2024
@time-and-fate time-and-fate added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Feb 27, 2024
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Merging #51363 (e2e78cb) into master (6f02e99) will increase coverage by 2.1215%.
Report is 10 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #51363        +/-   ##
================================================
+ Coverage   70.5756%   72.6972%   +2.1215%     
================================================
  Files          1462       1461         -1     
  Lines        434885     435516       +631     
================================================
+ Hits         306923     316608      +9685     
+ Misses       108661      98973      -9688     
- Partials      19301      19935       +634     
Flag Coverage Δ
integration 48.9393% <100.0000%> (?)
unit 70.4011% <100.0000%> (+0.0324%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.4045% <ø> (+5.5816%) ⬆️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 27, 2024
Copy link

ti-chi-bot bot commented Feb 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tangenta, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 27, 2024
Copy link

ti-chi-bot bot commented Feb 27, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-27 09:56:05.387976436 +0000 UTC m=+955854.135599547: ☑️ agreed by tangenta.
  • 2024-02-27 10:50:01.993695037 +0000 UTC m=+959090.741318149: ☑️ agreed by winoros.

@ti-chi-bot ti-chi-bot bot merged commit 961159c into pingcap:master Feb 27, 2024
22 of 23 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #51373.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
4 participants