util/ranger: do not convert to binary collate for string values when convertToSortKey is false (#51363)

[ti-chi-bot]

This is an automated cherry-pick of #51363

What problem does this PR solve?

Issue Number: close #51316

Problem Summary:

As said in 3. of #48522, convertStringFTToBinaryCollate should be used only for the new convertToSortKey case.

But in the code, among the 4 places convertStringFTToBinaryCollate is called, 2 of them missed this check, and resulted in values with wrong types in the result Range.

Currently convertToSortKey = false is only used for partition pruning.

What changed and how does it work?

As the title says, add check for convertToSortKey when using convertStringFTToBinaryCollate.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tangenta, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [tangenta,winoros]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-02-27 12:18:27.291722235 +0000 UTC m=+964396.039345349: ☑️ agreed by tangenta.
• 2024-02-27 12:23:39.79335665 +0000 UTC m=+964708.540979763: ☑️ agreed by winoros.

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (release-7.5@6608c98). Click here to learn what that means.
The diff coverage is 100.0000%.

Additional details and impacted files

@@               Coverage Diff                @@
##             release-7.5     #51373   +/-   ##
================================================
  Coverage               ?   71.9577%           
================================================
  Files                  ?       1407           
  Lines                  ?     408729           
  Branches               ?          0           
================================================
  Hits                   ?     294112           
  Misses                 ?      94807           
  Partials               ?      19810           

Flag	Coverage Δ
unit	71.9577% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	53.9913% <0.0000%> (?)
parser	∅ <0.0000%> (?)
br	53.3649% <0.0000%> (?)