Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: start to listen after init stats complete #51472

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Mar 4, 2024

What problem does this PR solve?

Issue Number: close #51473

Problem Summary:

What changed and how does it work?

Now the checkpoint of force-init-stats is before the TCP accept handler. it should be before establishing the TCP listener.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Add the sleep into the checkpoint of force-init-stats. then we cannot connect it.

we cannot add it to UT. because it takes too much time for UT to sleep duration running.

  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/needs-triage-completed labels Mar 4, 2024
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Merging #51472 (8549d8c) into master (99390e2) will increase coverage by 2.0250%.
Report is 13 commits behind head on master.
The diff coverage is 80.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #51472        +/-   ##
================================================
+ Coverage   70.7316%   72.7567%   +2.0250%     
================================================
  Files          1462       1462                
  Lines        435276     436669      +1393     
================================================
+ Hits         307878     317706      +9828     
+ Misses       108109      99015      -9094     
- Partials      19289      19948       +659     
Flag Coverage Δ
integration 48.8914% <33.3333%> (?)
unit 70.5177% <80.0000%> (-0.0183%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 50.9120% <ø> (+5.0639%) ⬆️

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 4, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 5, 2024
Copy link
Contributor

@elsa0520 elsa0520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 5, 2024
Copy link

ti-chi-bot bot commented Mar 5, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-05 03:29:54.814579041 +0000 UTC m=+137821.836825433: ☑️ agreed by tiancaiamao.
  • 2024-03-05 03:46:36.165933306 +0000 UTC m=+138823.188179694: ☑️ agreed by elsa0520.

Copy link
Contributor

@3pointer 3pointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BR part LGTM

Copy link

ti-chi-bot bot commented Mar 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, elsa0520, lance6716, tiancaiamao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Mar 5, 2024
@hawkingrei
Copy link
Member Author

/retest

1 similar comment
@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 7f8d394 into pingcap:master Mar 5, 2024
35 checks passed
@hawkingrei hawkingrei deleted the fix_init_stats branch March 5, 2024 09:15
@hawkingrei
Copy link
Member Author

/cherrypick release-7.5
/cherrypick release-7.1
/cherrypick release-6.5

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Mar 5, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-6.5: #51511.

In response to this:

/cherrypick release-7.5
/cherrypick release-7.1
/cherrypick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-7.1: #51512.

In response to this:

/cherrypick release-7.5
/cherrypick release-7.1
/cherrypick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Mar 5, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Mar 5, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-7.5: #51513.

In response to this:

/cherrypick release-7.5
/cherrypick release-7.1
/cherrypick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

hawkingrei added a commit to ti-chi-bot/tidb that referenced this pull request Mar 8, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
hawkingrei added a commit to ti-chi-bot/tidb that referenced this pull request Mar 10, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@hawkingrei
Copy link
Member Author

/cherrypick release-7.5-20240311-v7.5.1

@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-7.5-20240311-v7.5.1: #51645.

In response to this:

/cherrypick release-7.5-20240311-v7.5.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Mar 11, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

listen the port before the init stats
6 participants