-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server: start to listen after init stats complete #51472
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51472 +/- ##
================================================
+ Coverage 70.7316% 72.7567% +2.0250%
================================================
Files 1462 1462
Lines 435276 436669 +1393
================================================
+ Hits 307878 317706 +9828
+ Misses 108109 99015 -9094
- Partials 19289 19948 +659
Flags with carried forward coverage won't be shown. Click here to find out more.
|
70f1056
to
9b2faef
Compare
151e1d7
to
ab5118e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[LGTM Timeline notifier]Timeline:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BR part LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3pointer, elsa0520, lance6716, tiancaiamao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
/cherrypick release-7.5 |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@hawkingrei: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
@hawkingrei: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@hawkingrei: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
/cherrypick release-7.5-20240311-v7.5.1 |
@hawkingrei: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
What problem does this PR solve?
Issue Number: close #51473
Problem Summary:
What changed and how does it work?
Now the checkpoint of
force-init-stats
is before the TCPaccept
handler. it should be before establishing the TCP listener.Check List
Tests
Add the sleep into the checkpoint of
force-init-stats
. then we cannot connect it.we cannot add it to UT. because it takes too much time for UT to sleep duration running.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.