-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server: start to listen after init stats complete (#51472) #51512
server: start to listen after init stats complete (#51472) #51512
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fixdb, hawkingrei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-7.1 #51512 +/- ##
================================================
Coverage ? 73.4353%
================================================
Files ? 1212
Lines ? 379504
Branches ? 0
================================================
Hits ? 278690
Misses ? 83030
Partials ? 17784 |
This is an automated cherry-pick of #51472
What problem does this PR solve?
Issue Number: close #51473
Problem Summary:
What changed and how does it work?
Now the checkpoint of
force-init-stats
is before the TCPaccept
handler. it should be before establishing the TCP listener.Check List
Tests
Add the sleep into the checkpoint of
force-init-stats
. then we cannot connect it.we cannot add it to UT. because it takes too much time for UT to sleep duration running.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.