Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

domain: avoid panic in the init stats breaking the loadStatsWorker (#51579) #51756

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #51579

What problem does this PR solve?

Issue Number: close #51581

Problem Summary:

What changed and how does it work?

If init-stats panics, then the load stats of this instance will all be broken.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Mar 14, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Mar 14, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Mar 14, 2024
Copy link

ti-chi-bot bot commented Mar 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 14, 2024
Copy link

ti-chi-bot bot commented Mar 14, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-14 07:34:51.756061944 +0000 UTC m=+930118.778308317: ☑️ agreed by hawkingrei.
  • 2024-03-14 12:41:35.801412727 +0000 UTC m=+948522.823659118: ☑️ agreed by winoros.

@hawkingrei
Copy link
Member

/retest

1 similar comment
@hawkingrei
Copy link
Member

/retest

Copy link

codecov bot commented Mar 17, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@2b8a5fa). Click here to learn what that means.
The diff coverage is 0.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #51756   +/-   ##
================================================
  Coverage               ?   73.7016%           
================================================
  Files                  ?       1095           
  Lines                  ?     350946           
  Branches               ?          0           
================================================
  Hits                   ?     258653           
  Misses                 ?      75723           
  Partials               ?      16570           

@ti-chi-bot ti-chi-bot bot merged commit 9ad6f42 into pingcap:release-6.5 Mar 17, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants