Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

domain: avoid panic in the init stats breaking the loadStatsWorker (#51579) #51756

Merged
merged 1 commit into from
Mar 17, 2024
Merged

domain: avoid panic in the init stats breaking the loadStatsWorker (#51579) #51756

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions domain/domain.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1930,6 +1930,10 @@
func (do *Domain) initStats() {
statsHandle := do.StatsHandle()
defer func() {
if r := recover(); r != nil {
logutil.BgLogger().Error("panic when initiating stats", zap.Any("r", r),
zap.Stack("stack"))
}

Check warning on line 1936 in domain/domain.go

View check run for this annotation

Codecov / codecov/patch

domain/domain.go#L1934-L1936 

Added lines #L1934 - L1936 were not covered by tests
close(statsHandle.InitStatsDone)
}()
t := time.Now()
Expand Down
Loading