-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extension: disable some optimizations for extension function #51926
Conversation
Hi @lcwangchao. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1f15126
to
a0bab23
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51926 +/- ##
=================================================
- Coverage 70.6700% 54.6307% -16.0393%
=================================================
Files 1477 1588 +111
Lines 438718 608384 +169666
=================================================
+ Hits 310042 332365 +22323
- Misses 109176 252925 +143749
- Partials 19500 23094 +3594
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qw4990, windtalker, YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a0bab23
to
31ff7ce
Compare
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #51925
Problem Summary:
If an extension function has some side-effect, it may be optimized by mistake. For example, if a function
myfunc
returns a random int,select id, myfunc() from t
may produce same values formyfunc
because it have been fold to a constant.Another problem is that if an extension function requires some privilege, it will only be checked when building it. That causes some problems when the plan cache is enabled because the privilege will not be check again when evaluating a function and a user's privileges may be revoked.
We should avoid these unnecessary optimizations.
What changed and how does it work?
Disable some optimizations for extension functions.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.