-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extension: disable some optimizations for extension function (#51926) #51946
extension: disable some optimizations for extension function (#51926) #51946
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
5af2471
to
44a21c2
Compare
44a21c2
to
d297be1
Compare
/approve |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #51946 +/- ##
================================================
Coverage ? 71.9901%
================================================
Files ? 1408
Lines ? 409110
Branches ? 0
================================================
Hits ? 294519
Misses ? 94770
Partials ? 19821
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lcwangchao, windtalker The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This is an automated cherry-pick of #51926
What problem does this PR solve?
Issue Number: close #51925
Problem Summary:
If an extension function has some side-effect, it may be optimized by mistake. For example, if a function
myfunc
returns a random int,select id, myfunc() from t
may produce same values formyfunc
because it have been fold to a constant.Another problem is that if an extension function requires some privilege, it will only be checked when building it. That causes some problems when the plan cache is enabled because the privilege will not be check again when evaluating a function and a user's privileges may be revoked.
We should avoid these unnecessary optimizations.
What changed and how does it work?
Disable some optimizations for extension functions.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.