Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extension: disable some optimizations for extension function (#51926) #51946

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #51926

What problem does this PR solve?

Issue Number: close #51925

Problem Summary:

If an extension function has some side-effect, it may be optimized by mistake. For example, if a function myfunc returns a random int, select id, myfunc() from t may produce same values for myfunc because it have been fold to a constant.

Another problem is that if an extension function requires some privilege, it will only be checked when building it. That causes some problems when the plan cache is enabled because the privilege will not be check again when evaluating a function and a user's privileges may be revoked.

We should avoid these unnecessary optimizations.

What changed and how does it work?

Disable some optimizations for extension functions.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Mar 20, 2024
@ti-chi-bot ti-chi-bot added cherry-pick-approved Cherry pick PR approved by release team. labels Mar 20, 2024
@lcwangchao lcwangchao force-pushed the cherry-pick-51926-to-release-7.5 branch from 5af2471 to 44a21c2 Compare March 20, 2024 09:05
@lcwangchao lcwangchao force-pushed the cherry-pick-51926-to-release-7.5 branch from 44a21c2 to d297be1 Compare March 20, 2024 09:18
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 20, 2024
@lcwangchao
Copy link
Collaborator

/approve

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-7.5@19f64a6). Click here to learn what that means.
The diff coverage is 66.6666%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #51946   +/-   ##
================================================
  Coverage               ?   71.9901%           
================================================
  Files                  ?       1408           
  Lines                  ?     409110           
  Branches               ?          0           
================================================
  Hits                   ?     294519           
  Misses                 ?      94770           
  Partials               ?      19821           
Flag Coverage Δ
unit 71.9901% <66.6666%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.3342% <0.0000%> (?)

Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Apr 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcwangchao, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 7, 2024
Copy link

ti-chi-bot bot commented Apr 7, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-20 09:29:57.07470495 +0000 UTC m=+1455424.096951323: ☑️ agreed by lcwangchao.
  • 2024-04-07 06:52:58.250107384 +0000 UTC m=+772439.777647930: ☑️ agreed by windtalker.

@ti-chi-bot ti-chi-bot bot merged commit 2d6302d into pingcap:release-7.5 Apr 7, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants